[miio] Add support for BT Gateway switch on chuangmi.plug.212a01 #11657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcelrv
added
the
enhancement
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
fwolter
requested changes
Nov 29, 2021
Comment on lines
126
to
127
| public static JsonElement getJsonElement(String element, JsonElement responseValue) | ||
| throws ClassCastException, IllegalStateException { |
There was a problem hiding this comment.
You'd better know before accessing it if it's the right type in the right state. Catching these is bad.
There was a problem hiding this comment.
maybe I'm overly causious here.. as the responsevalue is something that comes from the device and can have rather unexpected values I normally rather have a friendly message than an ugly stacktrace.
That said, I think the code indeed has little chance to generate these errors even in case of strange inputs so i'll remove it
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
wborn
changed the title
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
…nhab#11657) * [miio] add support for BT Gateway switch on chuangmi.plug.212a01 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] improve conversion & add test for it Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one empty string test Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] remove unnessesary exceptions Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one more test for different inputs Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] typo Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
…nhab#11657) * [miio] add support for BT Gateway switch on chuangmi.plug.212a01 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] improve conversion & add test for it Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one empty string test Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] remove unnessesary exceptions Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one more test for different inputs Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] typo Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
…nhab#11657) * [miio] add support for BT Gateway switch on chuangmi.plug.212a01 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] improve conversion & add test for it Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one empty string test Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] remove unnessesary exceptions Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one more test for different inputs Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] typo Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
volkmarnissen
pushed a commit
to volkmarnissen/openhab-addons
that referenced
this pull request
Mar 3, 2022
…nhab#11657) * [miio] add support for BT Gateway switch on chuangmi.plug.212a01 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] improve conversion & add test for it Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one empty string test Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] remove unnessesary exceptions Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one more test for different inputs Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] typo Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…nhab#11657) * [miio] add support for BT Gateway switch on chuangmi.plug.212a01 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] improve conversion & add test for it Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one empty string test Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] remove unnessesary exceptions Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one more test for different inputs Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] typo Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…nhab#11657) * [miio] add support for BT Gateway switch on chuangmi.plug.212a01 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] improve conversion & add test for it Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one empty string test Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] remove unnessesary exceptions Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add one more test for different inputs Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] typo Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com