Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miio] Fix Error parsing miot data null for new miot devices #11658

Merged
merged 1 commit into from Nov 29, 2021

Conversation

marcelrv
Copy link
Contributor

Signed-off-by: Marcel Verpaalen marcel@verpaalen.com

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv added the bug An unexpected problem or unintended behavior of an add-on label Nov 28, 2021
@lolodomo
Copy link
Contributor

I do not see an obvious link between the code change and your PR title.

@marcelrv
Copy link
Contributor Author

marcelrv commented Nov 28, 2021

It is the error in the screen you see.. from( https://github.com/openhab/openhab-addons/blob/main/bundles/org.openhab.binding.miio/src/main/java/org/openhab/binding/miio/internal/miot/MiotParser.java#L84 )
Seems Xiaomi server no longer allows plain http, which results in a null, which gives this message

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@wborn wborn merged commit 497cffb into openhab:main Nov 29, 2021
@wborn wborn added this to the 3.2 milestone Nov 29, 2021
@marcelrv marcelrv deleted the miio-parserfix branch November 29, 2021 10:18
@wborn wborn changed the title [miio] fix Error parsing miot data null for new miot devices [miio] Fix Error parsing miot data null for new miot devices Dec 18, 2021
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
…#11658)

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
…#11658)

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
…#11658)

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
volkmarnissen pushed a commit to volkmarnissen/openhab-addons that referenced this pull request Mar 3, 2022
…#11658)

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…#11658)

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
…#11658)

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants