Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chromecast] Added configuration flag to disable background discovery #11689

Merged

Conversation

cweitkamp
Copy link
Contributor

  • Added configuration flag to disable background discovery

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp cweitkamp added the enhancement An enhancement or new feature for an existing add-on label Dec 2, 2021
@jlaur
Copy link
Contributor

jlaur commented Dec 2, 2021

Would it make sense to configure it from here?
image

image

@cweitkamp
Copy link
Contributor Author

cweitkamp commented Dec 2, 2021

In general it does make sense. But unfortunately it will not work. The discovery for Chromecast devices is a separate OSGi service decoupled from the binding itself. The location you are pointing to allows to add more configurations for the binding itself - it uses configuration prefix binding.chromecast. It is not allowed to reuse this configuration id for another service. Thus I had to define a new one discovery.chromecast.

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 7abd6b5 into openhab:main Dec 4, 2021
@lolodomo lolodomo added this to the 3.2 milestone Dec 4, 2021
@cweitkamp cweitkamp deleted the feature-chromecast-disable-discovery branch December 4, 2021 14:32
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
…openhab#11689)

* Added configuration flag to disable background discovery

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
…openhab#11689)

* Added configuration flag to disable background discovery

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
…openhab#11689)

* Added configuration flag to disable background discovery

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
volkmarnissen pushed a commit to volkmarnissen/openhab-addons that referenced this pull request Mar 3, 2022
…openhab#11689)

* Added configuration flag to disable background discovery

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…openhab#11689)

* Added configuration flag to disable background discovery

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
…openhab#11689)

* Added configuration flag to disable background discovery

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
…openhab#11689)

* Added configuration flag to disable background discovery

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants