[plugwise] Fix 'power' channel not correctly updated with power production #11746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction This fixes the issue that the 'power' channel would not update with the correct state because the number of pulses in the PowerInformationResponseMessage is signed instead of unsigned. When the binding detected these strange readings it would normally log: "Circle (...) is in a kind of error state ...". Signed-off-by: Wouter Born <github@maindrain.net>
|
Thank you @wborn for the fix, I'm still busy to capture the packets for the energy part. |
|
...and thank you for testing the changes! 👍 |
|
I am not sure about the cast to short but if it is tested and approved by users, that is fine for me. |
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
…ction (openhab#11746) This fixes the issue that the 'power' channel would not update with the correct state because the number of pulses in the PowerInformationResponseMessage is signed instead of unsigned. When the binding detected these strange readings it would normally log: "Circle (...) is in a kind of error state ...". Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
…ction (openhab#11746) This fixes the issue that the 'power' channel would not update with the correct state because the number of pulses in the PowerInformationResponseMessage is signed instead of unsigned. When the binding detected these strange readings it would normally log: "Circle (...) is in a kind of error state ...". Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
…ction (openhab#11746) This fixes the issue that the 'power' channel would not update with the correct state because the number of pulses in the PowerInformationResponseMessage is signed instead of unsigned. When the binding detected these strange readings it would normally log: "Circle (...) is in a kind of error state ...". Signed-off-by: Wouter Born <github@maindrain.net>
volkmarnissen
pushed a commit
to volkmarnissen/openhab-addons
that referenced
this pull request
Mar 3, 2022
…ction (openhab#11746) This fixes the issue that the 'power' channel would not update with the correct state because the number of pulses in the PowerInformationResponseMessage is signed instead of unsigned. When the binding detected these strange readings it would normally log: "Circle (...) is in a kind of error state ...". Signed-off-by: Wouter Born <github@maindrain.net>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…ction (openhab#11746) This fixes the issue that the 'power' channel would not update with the correct state because the number of pulses in the PowerInformationResponseMessage is signed instead of unsigned. When the binding detected these strange readings it would normally log: "Circle (...) is in a kind of error state ...". Signed-off-by: Wouter Born <github@maindrain.net>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…ction (openhab#11746) This fixes the issue that the 'power' channel would not update with the correct state because the number of pulses in the PowerInformationResponseMessage is signed instead of unsigned. When the binding detected these strange readings it would normally log: "Circle (...) is in a kind of error state ...". Signed-off-by: Wouter Born <github@maindrain.net>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…ction (openhab#11746) This fixes the issue that the 'power' channel would not update with the correct state because the number of pulses in the PowerInformationResponseMessage is signed instead of unsigned. When the binding detected these strange readings it would normally log: "Circle (...) is in a kind of error state ...". Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue that the 'power' channel would not update with the correct state because the number of pulses in the
PowerInformationResponseMessageis signed instead of unsigned.When the binding detected these strange readings it would normally log: "Circle (...) is in a kind of error state ...".
See also: https://community.openhab.org/t/plugwise-cirle-connected-to-pv-panel-gives-no-power-data-in-oh3/123001