Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hdpowerview] Fix deprecated channels on reinitialization #11779

Merged

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Dec 14, 2021

Fixes #11778

Signed-off-by: Jacob Laursen jacob-github@vindvejr.dk

Regression of #11637

Fixes openhab#11778

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur
Copy link
Contributor Author

jlaur commented Dec 14, 2021

@arroyoj
Copy link

arroyoj commented Dec 14, 2021

@jlaur, thanks for the quick fix of #11778. I tested out the JAR that you posted and it fixed the issue. The deprecated channels are being created properly both on openhab startup as well as when the hub Thing is saved/reinitialized. The scene channels worked and nothing seemed broken. Thanks!

@jlaur jlaur marked this pull request as ready for review December 14, 2021 13:22
@jlaur
Copy link
Contributor Author

jlaur commented Dec 14, 2021

@fwolter - please consider this regression bugfix for 3.2. Sorry for the inconvenience.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit caa9e35 into openhab:main Dec 15, 2021
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Dec 15, 2021
@lolodomo lolodomo added this to the 3.2 milestone Dec 15, 2021
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
Fixes openhab#11778

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
Fixes openhab#11778

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
Fixes openhab#11778

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
volkmarnissen pushed a commit to volkmarnissen/openhab-addons that referenced this pull request Mar 3, 2022
Fixes openhab#11778

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Fixes openhab#11778

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur deleted the 11778-hdpowerview-fix-deprecated-channels branch June 13, 2022 18:50
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Fixes openhab#11778

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Fixes openhab#11778

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hdpowerview] Deprecated scene channels removed after saving hub configuration
3 participants