Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[irobot] Added zone support #11783

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Conversation

Nuesel
Copy link
Contributor

@Nuesel Nuesel commented Dec 14, 2021

Hello,
I bought a new iRobot Roomba i7. But I encountered the problem, the robot couldn't clean rooms nor zones defined in the iRobot app. See: #11340
I tested the code with the iRobot firmware 3.18.11 (currently up to date). The changes seem to work fine.
This PR replaces #11413 as this PR has gone mad, don't know what happened.
@lolodomo This pull request contains the same changes as in 11413. Thanks a lot for your patience.

Regards,
Nuesel

@lolodomo
Copy link
Contributor

Please sign correctly your PR. Looks at DCO check and click on details.

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Dec 15, 2021
Signed-off-by: Nuesel <nuesel@gruenbaer.net>
@lolodomo lolodomo merged commit e54dec5 into openhab:main Dec 16, 2021
@lolodomo lolodomo added this to the 3.2 milestone Dec 16, 2021
@wborn wborn changed the title iRobot zone support added [irobot] Added zone support Dec 18, 2021
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
Signed-off-by: Nuesel <nuesel@gruenbaer.net>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
Signed-off-by: Nuesel <nuesel@gruenbaer.net>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
Signed-off-by: Nuesel <nuesel@gruenbaer.net>
volkmarnissen pushed a commit to volkmarnissen/openhab-addons that referenced this pull request Mar 3, 2022
Signed-off-by: Nuesel <nuesel@gruenbaer.net>
@Nuesel Nuesel deleted the irobot_zonesupport branch April 11, 2022 17:54
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Signed-off-by: Nuesel <nuesel@gruenbaer.net>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Signed-off-by: Nuesel <nuesel@gruenbaer.net>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Signed-off-by: Nuesel <nuesel@gruenbaer.net>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants