Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[avmfritz] Prevent attempt to set brightness of blinds #11790

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

quidam
Copy link
Contributor

@quidam quidam commented Dec 15, 2021

This is a bug fix for issue #11789. It prevents the AVMFritzBaseThingHandler from attempting to set the (non-existing) brightness channel for HAN-FUN blinds.

Signed-off-by: Ulrich Mertin mail@ulrich-mertin.de

Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 956f6e7 into openhab:main Dec 15, 2021
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Dec 15, 2021
@lolodomo lolodomo added this to the 3.2 milestone Dec 15, 2021
@cweitkamp
Copy link
Contributor

Thanks for looking into this. With my fix in #11773 this check is not needed anymore. But I think it will not hurt too. 😉 .

Two people one thought.

@quidam quidam deleted the 11789-fix-for-avmfritz-blinds branch December 15, 2021 19:05
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
volkmarnissen pushed a commit to volkmarnissen/openhab-addons that referenced this pull request Mar 3, 2022
Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Signed-off-by: Ulrich Mertin <mail@ulrich-mertin.de>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants