Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hdpowerview] Fix support for PowerView Hub v1 #11857

Merged
merged 1 commit into from Dec 26, 2021

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Dec 25, 2021

Fixes #11856

Signed-off-by: Jacob Laursen jacob-github@vindvejr.dk

Unfortunately #11534 has caused a regression in 3.2 since scene collection URL's were renamed in Hunter Douglas PowerView Hub v2.

This pull request is a limited version of #11853 fixing only the needed lines for Hub v1 compatibility and preserving scene group support for both Hub versions.

If there will be a branch for 3.2.x hotfixes, this PR would be a candidate.

Fixes openhab#11856

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur changed the title [hdpowerview] Fix support for Hub v1 [hdpowerview] Fix support for PowerView Hub v1 Dec 25, 2021
@jlaur
Copy link
Contributor Author

jlaur commented Dec 25, 2021

JAR for this PR. However, please consider testing JAR from #11853 since it contains more changes (including this one).

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 155ecf4 into openhab:main Dec 26, 2021
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Dec 26, 2021
@lolodomo lolodomo added this to the 3.3 milestone Dec 26, 2021
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
Fixes openhab#11856

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
Fixes openhab#11856

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
moesterheld pushed a commit to moesterheld/openhab-addons that referenced this pull request Jan 18, 2022
Fixes openhab#11856

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
Fixes openhab#11856

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur added a commit that referenced this pull request Feb 4, 2022
Fixes #11856

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
volkmarnissen pushed a commit to volkmarnissen/openhab-addons that referenced this pull request Mar 3, 2022
Fixes openhab#11856

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@wborn wborn added the patch A PR that has been cherry-picked to a patch release branch label Apr 6, 2022
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Fixes openhab#11856

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur deleted the 11856-hdpowerview-hub-v1-compatibility branch June 13, 2022 18:47
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Fixes openhab#11856

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Fixes openhab#11856

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hdpowerview] All things are offline with PowerView Hub v1
3 participants