New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hdpowerview] Fix support for PowerView Hub v1 #11857
Merged
lolodomo
merged 1 commit into
openhab:main
from
jlaur:11856-hdpowerview-hub-v1-compatibility
Dec 26, 2021
Merged
[hdpowerview] Fix support for PowerView Hub v1 #11857
lolodomo
merged 1 commit into
openhab:main
from
jlaur:11856-hdpowerview-hub-v1-compatibility
Dec 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openhab#11856 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
This was referenced Dec 25, 2021
jlaur
changed the title
[hdpowerview] Fix support for Hub v1
[hdpowerview] Fix support for PowerView Hub v1
Dec 25, 2021
lolodomo
approved these changes
Dec 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
Fixes openhab#11856 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
Fixes openhab#11856 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
moesterheld
pushed a commit
to moesterheld/openhab-addons
that referenced
this pull request
Jan 18, 2022
Fixes openhab#11856 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
Fixes openhab#11856 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
added a commit
that referenced
this pull request
Feb 4, 2022
Fixes #11856 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
volkmarnissen
pushed a commit
to volkmarnissen/openhab-addons
that referenced
this pull request
Mar 3, 2022
Fixes openhab#11856 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Fixes openhab#11856 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
Fixes openhab#11856 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
Fixes openhab#11856 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11856
Signed-off-by: Jacob Laursen jacob-github@vindvejr.dk
Unfortunately #11534 has caused a regression in 3.2 since scene collection URL's were renamed in Hunter Douglas PowerView Hub v2.
This pull request is a limited version of #11853 fixing only the needed lines for Hub v1 compatibility and preserving scene group support for both Hub versions.
If there will be a branch for 3.2.x hotfixes, this PR would be a candidate.