Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt.homie] Add DateTime channel type to comply with MQTT Homie convention 3.x #11894

Merged
merged 1 commit into from
Jan 6, 2022
Merged

[mqtt.homie] Add DateTime channel type to comply with MQTT Homie convention 3.x #11894

merged 1 commit into from
Jan 6, 2022

Conversation

LukasA83
Copy link
Contributor

@LukasA83 LukasA83 commented Dec 30, 2021

This adds support for DateTime channels to the mqtt homie binding, see https://homieiot.github.io/specification/#datetime

Relates to #10839

Signed-off-by: Lukas Agethen <lukas83@gmx.de>
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Dec 30, 2021
@LukasA83
Copy link
Contributor Author

LukasA83 commented Jan 6, 2022

Can somebody please review? Not sure, if @davidgraeff is still active on openhab?!

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jlaur jlaur changed the title [MQTT.Homie] Add DateTime channel type to comply with mqtt homie convention 3.x [mqtt.homie] Add DateTime channel type to comply with MQTT Homie convention 3.x Jan 6, 2022
@jlaur jlaur merged commit 1280a0e into openhab:main Jan 6, 2022
@jlaur jlaur added this to the 3.3 milestone Jan 6, 2022
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
…penhab#11894)

Signed-off-by: Lukas Agethen <lukas83@gmx.de>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
moesterheld pushed a commit to moesterheld/openhab-addons that referenced this pull request Jan 18, 2022
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
volkmarnissen pushed a commit to volkmarnissen/openhab-addons that referenced this pull request Mar 3, 2022
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
…penhab#11894)

Signed-off-by: Lukas Agethen <lukas83@gmx.de>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
…penhab#11894)

Signed-off-by: Lukas Agethen <lukas83@gmx.de>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants