[voicerss] Fix and enhance the external tool to prefill the cache #12155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
added
bug
|
To run this tool in a console command, you need to specify the classpath of 1 the voicerss jar and 2 the core.audio jar. This is even not enough as slf4j jar is still missing. I don't find this slf4j jar in a standard user installation. Should I update the POM file to build a specific additional jar (for this tool) including all the necessary dependencies ? |
|
I just realized the dependency of the cache tool with core openHAB was introduced by recently merged PR #11916 . |
lolodomo
force-pushed
the
voicerss_cache_tool
branch
2 times, most recently
from
9bea0de
to
656b2bd
Compare
|
The 2 problems are solved:
The PR is ready for a review. |
Make the tool independent of core openHAB Fix the parsing of the command arguments. Allow to provide optional audio codec and format. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
voicerss_cache_tool
branch
from
656b2bd
to
a621d4d
Compare
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
jlaur
requested changes
Jan 30, 2022
...hab.voice.voicerss/src/main/java/org/openhab/voice/voicerss/internal/VoiceRSSTTSService.java
Show resolved
Hide resolved
...hab.voice.voicerss/src/main/java/org/openhab/voice/voicerss/internal/VoiceRSSTTSService.java
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
volkmarnissen
pushed a commit
to volkmarnissen/openhab-addons
that referenced
this pull request
Mar 3, 2022
…enhab#12155) * [voicerss] Fix and enhance the external tool to prefill the cache * Make the tool independent of core openHAB * Fix the parsing of the command arguments. * Allow to provide optional audio codec and format. * Null annotations added on most of the classes * Simplified doc about classpath * Suppress obsolete mention of open issue in doc Signed-off-by: Laurent Garnier <lg.hc@free.fr>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
…enhab#12155) * [voicerss] Fix and enhance the external tool to prefill the cache * Make the tool independent of core openHAB * Fix the parsing of the command arguments. * Allow to provide optional audio codec and format. * Null annotations added on most of the classes * Simplified doc about classpath * Suppress obsolete mention of open issue in doc Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jun 29, 2022
…enhab#12155) * [voicerss] Fix and enhance the external tool to prefill the cache * Make the tool independent of core openHAB * Fix the parsing of the command arguments. * Allow to provide optional audio codec and format. * Null annotations added on most of the classes * Simplified doc about classpath * Suppress obsolete mention of open issue in doc Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…enhab#12155) * [voicerss] Fix and enhance the external tool to prefill the cache * Make the tool independent of core openHAB * Fix the parsing of the command arguments. * Allow to provide optional audio codec and format. * Null annotations added on most of the classes * Simplified doc about classpath * Suppress obsolete mention of open issue in doc Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…enhab#12155) * [voicerss] Fix and enhance the external tool to prefill the cache * Make the tool independent of core openHAB * Fix the parsing of the command arguments. * Allow to provide optional audio codec and format. * Null annotations added on most of the classes * Simplified doc about classpath * Suppress obsolete mention of open issue in doc Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…enhab#12155) * [voicerss] Fix and enhance the external tool to prefill the cache * Make the tool independent of core openHAB * Fix the parsing of the command arguments. * Allow to provide optional audio codec and format. * Null annotations added on most of the classes * Simplified doc about classpath * Suppress obsolete mention of open issue in doc Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the tool independent of core openHAB
Fix the parsing of the command arguments.
Allow to provide optional audio codec and format.
Null annotations added on most of the classes
Signed-off-by: Laurent Garnier lg.hc@free.fr