[tesla] Introduce "allowWakeUpForCommands" option #12184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <kai@openhab.org>
kaikreuzer
added
the
enhancement
kaikreuzer
changed the title
lolodomo
requested changes
Feb 2, 2022
...ding.tesla/src/main/java/org/openhab/binding/tesla/internal/handler/TeslaAccountHandler.java
Show resolved
Hide resolved
...ding.tesla/src/main/java/org/openhab/binding/tesla/internal/handler/TeslaAccountHandler.java
Show resolved
Hide resolved
| @@ -136,6 +136,12 @@ | |||
| <label>Allow Wake-Up</label> | |||
| <description>Allows waking up the vehicle. Caution: This can result in huge vampire drain!</description> | |||
| </parameter> | |||
| <parameter name="allowWakeupForCommands" type="boolean" required="false"> | |||
| <default>false</default> | |||
| <label>Allow Wake-Up For Commands</label> | |||
There was a problem hiding this comment.
Please update the file tesla.properties.
There was a problem hiding this comment.
Done, thanks for noticing, I always forget...
Signed-off-by: Kai Kreuzer <kai@openhab.org>
volkmarnissen
pushed a commit
to volkmarnissen/openhab-addons
that referenced
this pull request
Mar 3, 2022
* Introduce "allowWakeUpForCommands" option Signed-off-by: Kai Kreuzer <kai@openhab.org>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
* Introduce "allowWakeUpForCommands" option Signed-off-by: Kai Kreuzer <kai@openhab.org> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jun 29, 2022
* Introduce "allowWakeUpForCommands" option Signed-off-by: Kai Kreuzer <kai@openhab.org>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* Introduce "allowWakeUpForCommands" option Signed-off-by: Kai Kreuzer <kai@openhab.org>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* Introduce "allowWakeUpForCommands" option Signed-off-by: Kai Kreuzer <kai@openhab.org> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* Introduce "allowWakeUpForCommands" option Signed-off-by: Kai Kreuzer <kai@openhab.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new configuration option to the vehicle thing, which allows the binding to wake up the vehicle in case that commands are sent to it.
This is specifically handy for things like activating the auto-conditioning, Sentry mode or similar things.
As waking up the vehicle usually takes ~15 seconds, sending the command is retried 3 times (with 15 secs pause) until it succeeds. Naturally, this means that the command is not executed immediately, but that it is delayed by a considerable time.
Signed-off-by: Kai Kreuzer kai@openhab.org