Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[danfossairunit] Fix already configured units in inbox #12217

Merged
merged 1 commit into from
Feb 6, 2022

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Feb 5, 2022

Fixes #12216

Signed-off-by: Jacob Laursen jacob-github@vindvejr.dk

Fix entries in inbox for already configured units.

Fixes openhab#12216

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Feb 5, 2022
@jlaur jlaur requested a review from pravussum as a code owner February 5, 2022 22:17
@jlaur jlaur linked an issue Feb 5, 2022 that may be closed by this pull request
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

lolodomo commented Feb 6, 2022

This was already set correctly by the discovery class, so need to other change than what you proposed.

@lolodomo lolodomo merged commit 1422253 into openhab:main Feb 6, 2022
@lolodomo lolodomo added this to the 3.3 milestone Feb 6, 2022
@jlaur
Copy link
Contributor Author

jlaur commented Feb 6, 2022

This was already set correctly by the discovery class, so need to other change than what you proposed.

Not sure what you mean? You are right about discovery class, so should be in sync now:

                DiscoveryResult result = DiscoveryResultBuilder.create(uid).withRepresentationProperty("host")
                        .withProperties(properties).withLabel("Danfoss HRV").build();

@lolodomo
Copy link
Contributor

lolodomo commented Feb 6, 2022

Yes, I was just mentioning your change in the XML file was sufficient.

volkmarnissen pushed a commit to volkmarnissen/openhab-addons that referenced this pull request Mar 3, 2022
Fixes openhab#12216

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
Fixes openhab#12216

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
@jlaur jlaur deleted the 12216-danfossairunit-inbox-duplicate branch June 13, 2022 16:56
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jun 29, 2022
Fixes openhab#12216

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Fixes openhab#12216

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Fixes openhab#12216

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Fixes openhab#12216

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[danfossairunit] Duplicate inbox entry (file-based configuration)
2 participants