[bluetooth.airthings] Catch all exceptions in a scheduled task to prevent future executions from being suppressed #12261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawel-sw
changed the title
Catch all exceptions in scheduled task to prevent future executions from being suppressed. Signed-off-by: Pawel Switalski <switalski.pw@gmail.com> Signed-off-by: Pawel <s-pw@example.com>
pawel-sw
force-pushed
the
fix-9862-airthings
branch
from
07f8d18
to
4e0f4b9
Compare
lolodomo
requested changes
Feb 15, 2022
| ConnectionState connectionState = device.getConnectionState(); | ||
| logger.debug("Device {} state is {}, serviceState {}, readState {}", address, connectionState, serviceState, | ||
| readState); | ||
| try { |
There was a problem hiding this comment.
Following your (good) argument, the try/catch should be put in method executePeridioc, not method execute
Catch all exceptions in scheduled task to prevent future executions from being suppressed. Signed-off-by: Pawel Switalski <switalski.pw@gmail.com> Signed-off-by: Pawel <s-pw@example.com>
pawel-sw
force-pushed
the
fix-9862-airthings
branch
from
065ac96
to
c04045c
Compare
added 2 commits
February 15, 2022 20:23
Catch all exceptions in scheduled task to prevent future executions from being suppressed. Signed-off-by: Pawel Switalski <switalski.pw@gmail.com> Signed-off-by: Pawel <s-pw@example.com>
Catch all exceptions in scheduled task to prevent future executions from being suppressed. Signed-off-by: Pawel Switalski <switalski.pw@gmail.com> Signed-off-by: Pawel <s-pw@example.com>
pawel-sw
force-pushed
the
fix-9862-airthings
branch
from
e4abe20
to
aca4e81
Compare
volkmarnissen
pushed a commit
to volkmarnissen/openhab-addons
that referenced
this pull request
Mar 3, 2022
…vent future executions from being suppressed (openhab#12261) * Fixes openhab#9862 Catch all exceptions in scheduled task to prevent future executions from being suppressed. Signed-off-by: Pawel Switalski <switalski.pw@gmail.com> Signed-off-by: Pawel <s-pw@example.com>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
…vent future executions from being suppressed (openhab#12261) * Fixes openhab#9862 Catch all exceptions in scheduled task to prevent future executions from being suppressed. Signed-off-by: Pawel Switalski <switalski.pw@gmail.com> Signed-off-by: Pawel <s-pw@example.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jun 29, 2022
…vent future executions from being suppressed (openhab#12261) * Fixes openhab#9862 Catch all exceptions in scheduled task to prevent future executions from being suppressed. Signed-off-by: Pawel Switalski <switalski.pw@gmail.com> Signed-off-by: Pawel <s-pw@example.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…vent future executions from being suppressed (openhab#12261) * Fixes openhab#9862 Catch all exceptions in scheduled task to prevent future executions from being suppressed. Signed-off-by: Pawel Switalski <switalski.pw@gmail.com> Signed-off-by: Pawel <s-pw@example.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…vent future executions from being suppressed (openhab#12261) * Fixes openhab#9862 Catch all exceptions in scheduled task to prevent future executions from being suppressed. Signed-off-by: Pawel Switalski <switalski.pw@gmail.com> Signed-off-by: Pawel <s-pw@example.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…vent future executions from being suppressed (openhab#12261) * Fixes openhab#9862 Catch all exceptions in scheduled task to prevent future executions from being suppressed. Signed-off-by: Pawel Switalski <switalski.pw@gmail.com> Signed-off-by: Pawel <s-pw@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9862
Signed-off-by: Pawel Switalski switalski.pw@gmail.com