[openweathermap] Cleanup semantic tags #12285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to openhab#12262 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
36 tasks
kaikreuzer
reviewed
Feb 13, 2022
| @@ -507,10 +503,6 @@ | |||
| <label>Precipitation</label> | |||
| <description>Precipitation volume of the related timespan.</description> | |||
| <category>Rain</category> | |||
| <tags> | |||
| <tag>Measurement</tag> | |||
| <tag>Rain</tag> | |||
There was a problem hiding this comment.
Which rule do these tags break? Is it because it implicitly refers to an (undefined) measurement period?
There was a problem hiding this comment.
In fact, it is forecasted precipitations. It is a channel type only member of group named oneCallMinutely having this label "One Call API Minutely Forecast". Maybe the channel label or description could be improved (in a separate PR).
There was a problem hiding this comment.
Ok, I indeed didn't notice this as I didn't look at the channel group of it. Thanks for the explanation!
There was a problem hiding this comment.
And you have another channel type "rain" with tags Measurment + Rain.
volkmarnissen
pushed a commit
to volkmarnissen/openhab-addons
that referenced
this pull request
Mar 3, 2022
Related to openhab#12262 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
Related to openhab#12262 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jun 29, 2022
Related to openhab#12262 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
Related to openhab#12262 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
Related to openhab#12262 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
Related to openhab#12262 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12262
Signed-off-by: Laurent Garnier lg.hc@free.fr