Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bluetooth.govee] Fix Govee H5102 detection #12373

Merged
merged 1 commit into from
Feb 26, 2022
Merged

Conversation

davidoe
Copy link
Contributor

@davidoe davidoe commented Feb 25, 2022

This patch enables detection of my Govee H5102, which identifies as "GVH5102_77E9", not "Govee H5102..", as expected in GoveeModel.

@lolodomo lolodomo changed the title fix Govee H5102 detection [govee] fix Govee H5102 detection Feb 26, 2022
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Feb 26, 2022
Signed-off-by: davidoe <1133989+davidoe@users.noreply.github.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

Build is failing.

@lolodomo lolodomo added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Feb 26, 2022
@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Feb 26, 2022
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@wborn wborn merged commit 38c896e into openhab:main Feb 26, 2022
@wborn wborn changed the title [govee] fix Govee H5102 detection [govee] Fix Govee H5102 detection Feb 26, 2022
@wborn wborn added this to the 3.3 milestone Feb 26, 2022
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
Signed-off-by: davidoe <1133989+davidoe@users.noreply.github.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Signed-off-by: davidoe <1133989+davidoe@users.noreply.github.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Signed-off-by: davidoe <1133989+davidoe@users.noreply.github.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Signed-off-by: davidoe <1133989+davidoe@users.noreply.github.com>
@jlaur jlaur changed the title [govee] Fix Govee H5102 detection [bluetooth.govee] Fix Govee H5102 detection Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants