Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fronius] Add the new channels to the documentation #12394

Merged
merged 3 commits into from
Mar 5, 2022

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Mar 1, 2022

Add the documentation for the channels that were added in #10757

@jimtng jimtng requested a review from trokohl as a code owner March 1, 2022 12:54
@jimtng jimtng force-pushed the fronius-doc branch 2 times, most recently from cc1b939 to 94573b2 Compare March 2, 2022 23:10
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
bundles/org.openhab.binding.fronius/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.fronius/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.fronius/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.fronius/README.md Outdated Show resolved Hide resolved
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng
Copy link
Contributor Author

jimtng commented Mar 5, 2022

Added the missing dimensions

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit e6179aa into openhab:main Mar 5, 2022
@lolodomo lolodomo added this to the 3.3 milestone Mar 5, 2022
@jimtng jimtng deleted the fronius-doc branch March 5, 2022 10:08
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
* [fronius] Document the recently added inverter power and soc channels

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* [fronius] Document the recently added inverter power and soc channels

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* [fronius] Document the recently added inverter power and soc channels

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* [fronius] Document the recently added inverter power and soc channels

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants