Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wemo] Fix thing status transitions #12416

Merged
merged 4 commits into from Mar 5, 2022

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Mar 4, 2022

Fixes #12415

Signed-off-by: Jacob Laursen jacob-github@vindvejr.dk

Previously transitions for a turned off device would be:

2022-03-04 22:11:46.481 [INFO ] [ab.event.ThingStatusInfoChangedEvent] - Thing 'wemo:insight:insight1' changed from UNINITIALIZED (HANDLER_MISSING_ERROR) to INITIALIZING
2022-03-04 22:11:46.505 [INFO ] [ab.event.ThingStatusInfoChangedEvent] - Thing 'wemo:insight:insight1' changed from INITIALIZING to ONLINE
2022-03-04 22:11:57.366 [INFO ] [ab.event.ThingStatusInfoChangedEvent] - Thing 'wemo:insight:insight1' changed from ONLINE to ONLINE (CONFIGURATION_PENDING): UPnP device is not registered yet.

Now:

2022-03-04 22:25:21.030 [INFO ] [ab.event.ThingStatusInfoChangedEvent] - Thing 'wemo:insight:insight1' changed from UNINITIALIZED (HANDLER_MISSING_ERROR) to INITIALIZING
2022-03-04 22:25:21.067 [INFO ] [ab.event.ThingStatusInfoChangedEvent] - Thing 'wemo:insight:insight1' changed from INITIALIZING to UNKNOWN
2022-03-04 22:26:41.846 [INFO ] [ab.event.ThingStatusInfoChangedEvent] - Thing 'wemo:insight:insight1' changed from UNKNOWN to OFFLINE: UPnP device is not registered yet.

Fixes openhab#12415

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Mar 4, 2022
@jlaur jlaur requested a review from hmerk as a code owner March 4, 2022 21:41
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur force-pushed the 12415-wemo-status-transitions branch from 165267a to 76ceeb2 Compare March 4, 2022 22:45
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit a3b6f74 into openhab:main Mar 5, 2022
@lolodomo lolodomo added this to the 3.3 milestone Mar 5, 2022
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
* Fix status transitions

Fixes openhab#12415

* Fix integration tests
* Fix missing status update for some devices after HTTP call

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
@jlaur jlaur deleted the 12415-wemo-status-transitions branch June 13, 2022 16:44
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* Fix status transitions

Fixes openhab#12415

* Fix integration tests
* Fix missing status update for some devices after HTTP call

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* Fix status transitions

Fixes openhab#12415

* Fix integration tests
* Fix missing status update for some devices after HTTP call

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* Fix status transitions

Fixes openhab#12415

* Fix integration tests
* Fix missing status update for some devices after HTTP call

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wemo] Fix thing status transitions
2 participants