Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ambientweather] Update socket.io dependency used by ambientweather #12429

Merged
merged 1 commit into from
Mar 6, 2022

Conversation

ssalonen
Copy link
Contributor

@ssalonen ssalonen commented Mar 6, 2022

Discussed in #11153 (comment)

Signed-off-by: Sami Salonen ssalonen@gmail.com

Discussed in openhab#11153 (comment)

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
@ssalonen ssalonen requested a review from mhilbush as a code owner March 6, 2022 06:49
@ssalonen ssalonen requested a review from lolodomo March 6, 2022 06:50
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 4d01af7 into openhab:main Mar 6, 2022
@lolodomo
Copy link
Contributor

lolodomo commented Mar 6, 2022

Thank you

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Mar 6, 2022
@lolodomo lolodomo added this to the 3.3 milestone Mar 6, 2022
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
…penhab#12429)

Discussed in openhab#11153 (comment)

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
…penhab#12429)

Discussed in openhab#11153 (comment)

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants