[rotel] New channels tcbypass, balance, speakera and speakerb

[tonwi]

• [rotel] Extension of channel list for amplifiers A11, A12 and A14

The list of channels for the Rotel devices A11, A12 and A14 has been extended by 4 channels:

1. TONE-CONTROL-BYPASS (Switch)
   If TCBypass is ON the device "bypasses" any bass or treble adjustments.
   Instead, an optimal sound setting of the manufacturer is used
   in the case TCBypass is OFF the user is enabled to set his own bass and treble adjustments.
2. BALANCE (Number)
   The sound balance can be adjusted.
3. SPEAKER-A (Switch)
   A14 provides 2 speaker groups: A / B
   Channel/Item SPEAKER-A switches speaker group A ON or OFF respectively.
4. SPEAKER-B (Switch)
   A14 provides 2 speaker groups: A / B
   Channel/Item SPEAKER-B switches speaker group B ON or OFF respectively.

Signed-off-by: Wilhelm Tonsern wto.wit01@gmx.net

[lolodomo]

Please sign off properly (just a text to add in each of your commit).

I will start with a review of what you (wrongly?) changed in the existing code.

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/unable-to-git-push-my-binding-extensions/134031/7

[lolodomo]

Review part 1 of 3

[lolodomo]

@tonwi : I will continue my review this evening.

[lolodomo]

Review part 2 of 3

[tonwi]

I activated the "resove conversation" button: I don't know what that does. But i certainly don't want to end the conversation or delete it or....

[lolodomo]

I prefer you let me mark the conversation as resolved. This is easier for me to follow if the comments were considered. I do it after checking the changes done in the PR.

[lolodomo]

@tonwi : I just proposed changes (through a PR) to your branch. Please have a look.

[lolodomo]

I pushed my review comments as a PR to your repo.
Here are the remaining additional comments/questions.

[lolodomo]

@tonwi : with the changes I pushed to you, the code is now ready to add your new channels to other models including models supporting the "old" ASCII protocol. Once you merge my PR in your PR, I will propose to you a new small PR with channels added on other models.

[lolodomo]

@tonwi : with the changes I pushed to you, the code is now ready to add your new channels to other models including models supporting the "old" ASCII protocol. Once you merge my PR in your PR, I will propose to you a new small PR with channels added on other models.

This is now included in the PR I pushed to you.

[lolodomo]

This is also possible to handle speaker A and speaker B for the models RX-1050 and RX-1052. These models use the HEX protocol.
If you are fast to integrate my PR, I will do it later to not delay the merge of your PR.

[lolodomo]

This is also possible to handle speaker A and speaker B for the models RX-1050 and RX-1052. These models use the HEX protocol. If you are fast to integrate my PR, I will do it later to not delay the merge of your PR.

I do not remember why but these 2 models (RX-1050 and RX-1052) are not yet supported by the binding. So if I do something, this will be definitively in a separate PR.

[tonwi]

This is also possible to handle speaker A and speaker B for the models RX-1050 and RX-1052. These models use the HEX protocol. If you are fast to integrate my PR, I will do it later to not delay the merge of your PR.

Please give me advice how to "integrate your PR into mine"? Do I have to "git pull...." into my local branch? How should I do this? What I have to do? You must know: I do not have the slightest idea. My knowledge of "git" is very modest. Please give me advice!

[lolodomo]

First go to your Git page: tonwi#1
Look at my changes and if you are ok, merge the changes. That's all. Your remote branch will then include my changes and the current PR will even be updated.
If you want then to retrieve the code in your local branch from your remote branch, go into your local branch and the command should be something like: git pull tonwi a14-tonwi

[tonwi]

I destroyed my local repository completely.
In order to avoid erroneous "git push" commands and conflicts with this #12447 branch , i am informing you of an unimportant typo:
file: RotelConnec tor.java
line: 479
comment:
....The firmware expects values like r05 or L04 ....
should be
....The firmware expects values like r05 or l04 ....

[lolodomo]

I destroyed my local repository completely.

You can create it again from your remote branch:

git remote add tonwi https://github.com/tonwi/openhab-addons.git 
git fetch tonwi
git checkout -b a14-tonwi tonwi/a14-tonwi

i am informing you of an unimportant typo

Can you please fix it ?

[lolodomo]

And please discuss the last opened point ... so that we can quickly conclude this PR.

[lolodomo]

Just to be clear, here is how I imagine the final method:

    private void handleTcbypassCmd(String channel, Command command, RotelCommand onCmd, RotelCommand offCmd)
            throws RotelException, InterruptedException {
        if (command instanceof OnOffType) {
            if (command == OnOffType.ON) {
                connector.sendCommand(onCmd);
                bass = 0;
                treble = 0;
                updateChannelState(CHANNEL_BASS);
                updateChannelState(CHANNEL_TREBLE);
            } else if (command == OnOffType.OFF) {
                connector.sendCommand(offCmd);
                Thread.sleep(200);
                connector.sendCommand(RotelCommand.BASS);
                Thread.sleep(200);
                connector.sendCommand(RotelCommand.TREBLE);
            }
        } else {
            logger.debug("Command {} from channel {} failed: invalid command value", command, channel);
        }
    }

[tonwi]

it appears that it is working

[lolodomo]

LGTM

[lolodomo]

Thank you @tonwi for contributing to this binding. I will merge your PR this evening.