[openwebnet] Add support for sending Auxiliary (AUX) commands/messages to the bus (WHO=9) #12468

fabgio · 2022-03-13T13:32:42Z

This PR adds initial Auxiliary (AUX) message support to the binding (WHO=9) for sending AUX messages.
This PR closes #11515.

Description

This PR adds support for sending Auxiliary (AUX) WHO=9 messages to the Open Web Net binding.
With this addition BTicino BUS AUX (WHO=9) messages can be sent from OH3 allowing, for example, to control alarm systems of a BTicino installation.
Configuration for new things and channels has been added to the add-on README.

Test

Tested on BTicino/Legrand bulgrar-alarm unit 3486

mvalla

Thanks for this contribution. Beside the requested changes, two other things are missing:

discovery : give a look on how it is done in OpenWebNetDeviceDiscoveryService.java
event message handling: you should add here the new message type and then implement in the Aux Handler the method handleMessage() taking as an example what is done on the Scenario handler and in the updateDryContactIRState() method in particular

bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/BusAux.xml

bundles/org.openhab.binding.openwebnet/pom.xml

bundles/org.openhab.binding.openwebnet/README.md

...rc/main/java/org/openhab/binding/openwebnet/internal/handler/OpenWebNetAuxiliaryHandler.java

mvalla · 2022-03-19T18:14:13Z

Remember also to sign all commits otherwise the DCO check will not pass

bundles/org.openhab.binding.openwebnet/README.md

fabgio · 2022-03-22T16:14:06Z

Thank you so much for the PR approval and for your support as well!

mvalla · 2022-03-22T20:44:00Z

@lolodomo @fabgio I think before this PR is merged some testing would be useful, so I will first publish this on the marketplace so that users can be invited to do some testing using their configurations.

fabgio · 2022-03-27T13:05:48Z

@mvalla When are you going to publish the binding for testing? or would you prefer me to do that?

mvalla

I did a second review, see new comments

...java/org/openhab/binding/openwebnet/internal/discovery/OpenWebNetDeviceDiscoveryService.java

...rc/main/java/org/openhab/binding/openwebnet/internal/handler/OpenWebNetAuxiliaryHandler.java

fabgio · 2022-03-31T20:42:10Z

@mvalla tonight doing further tests the aux thing wasn't able to go online. Still when I did the last checks few days ago it was working properly... this is making me crazy. Just hold ... need some more testing...

openhab-bot · 2022-04-17T02:51:48Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openwebnet-binding-beta/129775/1

mvalla · 2022-04-19T08:32:25Z

after community testing these changed should be added:

explain clearly in README that AUX messages originating from BUS are not supported. Only sending commands from OH is supported for the moment. Create a new issue on GitHub for this.
in the AUX channel documentation in the README list all possible AUX values: ON, OFF, TOGGLE, STOP, UP, DOWN, ENABLED, DISABLED, RESET_GEN, RESET_BI, RESET_TRI. Also specify that for the moment only ON/OFF are supported.

mvalla

new change requested based on comments received. Remember to mark conversations as Resolved when changes have been commited.

bundles/org.openhab.binding.openwebnet/README.md

...java/org/openhab/binding/openwebnet/internal/discovery/OpenWebNetDeviceDiscoveryService.java

bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/channels.xml

...rc/main/java/org/openhab/binding/openwebnet/internal/handler/OpenWebNetAuxiliaryHandler.java

fabgio · 2022-04-23T19:58:43Z

Just a Maven question: How can I update artifact's name to include beta[n] postfix?
I have been seeking for a while!
Thanks

bundles/org.openhab.binding.openwebnet/README.md

mvalla

@fabgio please just implement these final suggested changes, and only them.
@jlaur Based on my review as code owner, after these last requested changes are implemented, the code can be accepted for merging. It is explained that it's an initial support for sending ON/OFF AUX commands on the BUS.

bundles/org.openhab.binding.openwebnet/README.md

mvalla · 2022-04-24T08:25:38Z

Just a Maven question: How can I update artifact's name to include beta[n] postfix? I have been seeking for a while! Thanks

it's not part of the integrated build process. You can rename the jar/kar manually after it's built.

bundles/org.openhab.binding.openwebnet/README.md

bundles/org.openhab.binding.openwebnet/pom.xml

...rc/main/java/org/openhab/binding/openwebnet/internal/handler/OpenWebNetAuxiliaryHandler.java

bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/BusAux.xml

bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/channels.xml

mvalla · 2022-05-04T03:55:56Z

Maybe is enough to do:

Copy as backup your binding directory somewhere else , just to be safe
then from openwebnet dir:

git fetch --all
git rebase -i upstream master
# fix all conflicting lines, but you should not find any 
git push -f

Starting a new PR means all this (long) discussion and all change suggestions are lost.

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

…me functionality (#11515) Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

…me functionality #11515) Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

…b community testing (#11515) Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

fabgio · 2022-05-04T16:40:29Z

@lolodomo @mvalla Ok I finally did an interactive rebase and dropped the unwanted commits. The PR gonna be ok now! Please Let me know...

lolodomo

Final review

bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/channels.xml

...rc/main/java/org/openhab/binding/openwebnet/internal/handler/OpenWebNetAuxiliaryHandler.java

bundles/org.openhab.binding.openwebnet/README.md

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

lolodomo

LGTM niw

fabgio · 2022-05-08T13:35:22Z

@lolodomo Thank you so much for your approval and support as well!

…s to the bus (WHO=9) (openhab#12468) Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com> Signed-off-by: Marc Fischer <marc.fischer2@bosch.io>

…s to the bus (WHO=9) (openhab#12468) Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

…s to the bus (WHO=9) (openhab#12468) Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>

…s to the bus (WHO=9) (openhab#12468) Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

fabgio changed the title ~~11515_openwebnet_3.3.0_aux_beta4~~ openwebnet] Add Auxiliary (AUX) message support to the binding (WHO=9) Mar 13, 2022

fabgio changed the title ~~openwebnet] Add Auxiliary (AUX) message support to the binding (WHO=9)~~ [openwebnet] Add Auxiliary (AUX) message support to the binding (WHO=9) Mar 13, 2022

jlaur added the enhancement An enhancement or new feature for an existing add-on label Mar 14, 2022

mvalla changed the title ~~[openwebnet] Add Auxiliary (AUX) message support to the binding (WHO=9)~~ [openwebnet] Add support for Auxiliary (AUX, WHO=9) messages Mar 16, 2022

fabgio marked this pull request as ready for review March 17, 2022 20:27

fabgio requested a review from mvalla as a code owner March 17, 2022 20:27

mvalla requested changes Mar 18, 2022

View reviewed changes

mvalla requested changes Mar 20, 2022

View reviewed changes

bundles/org.openhab.binding.openwebnet/README.md Outdated Show resolved Hide resolved

mvalla approved these changes Mar 21, 2022

View reviewed changes

mvalla added the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Mar 22, 2022

mvalla requested changes Mar 29, 2022

View reviewed changes

...java/org/openhab/binding/openwebnet/internal/discovery/OpenWebNetDeviceDiscoveryService.java Show resolved Hide resolved

...rc/main/java/org/openhab/binding/openwebnet/internal/handler/OpenWebNetAuxiliaryHandler.java Outdated Show resolved Hide resolved

mvalla requested changes Apr 19, 2022

View reviewed changes

fabgio changed the title ~~[openwebnet] Add support for Auxiliary (AUX, WHO=9) messages~~ [openwebnet] Add support for sending Auxiliary (AUX= commands/messages to the bus (WHO=9) Apr 22, 2022

fabgio changed the title ~~[openwebnet] Add support for sending Auxiliary (AUX= commands/messages to the bus (WHO=9)~~ [openwebnet] Add support for sending Auxiliary (AUX) commands/messages to the bus (WHO=9) Apr 22, 2022

jlaur mentioned this pull request Apr 23, 2022

[openwebnet] 3.3.0 aux beta6 (#11515) #12640

Closed

jlaur reviewed Apr 23, 2022

View reviewed changes

bundles/org.openhab.binding.openwebnet/README.md Show resolved Hide resolved

openhab deleted a comment from fabgio Apr 24, 2022

mvalla requested changes Apr 24, 2022

View reviewed changes

bundles/org.openhab.binding.openwebnet/README.md Outdated Show resolved Hide resolved

bundles/org.openhab.binding.openwebnet/README.md Outdated Show resolved Hide resolved

bundles/org.openhab.binding.openwebnet/README.md Outdated Show resolved Hide resolved

mvalla removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Apr 24, 2022

mvalla approved these changes Apr 24, 2022

View reviewed changes

lolodomo requested changes Apr 25, 2022

View reviewed changes

fabgio added 17 commits May 4, 2022 18:22

[openwebnet] Add BusAux thing and channel (#11515)

c932d3d

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

[openwebnet] Update Java constants to support aux (#11515)

df31c6e

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

[openwebnet] OpenWebNetAuxiliaryHandler implementation(#11515)

c367b64

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

[openwebnet] Allows Auxiliary Handler creation(#11515)

9e31abb

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

[openwebnet] Add unit tests for aux (#11515)

81dfde9

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

[openwebnet] Update README for aux(#11515)

337fd68

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

[openwebnet] Update pom to allow .kar artifact generation(#11515)

46b38c9

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

[openwebnet] Minor updates (#11515)

b595e58

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

squash! [openwebnet] Minor updates (#11515)

d7fda02

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

[openwebnet] Various fixes as per review (#11515)

8f6420e

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

[openwebnet] Add break statement in newDiscoveryResult() (#11515)

b3d06cd

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

[openwebnet] Aux thing stopped working. Override initialize() to resu…

427adce

…me functionality (#11515) Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

[openwebnet] Aux thing stopped working. Override initialize() to resu…

5f51a93

…me functionality #11515) Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

[openwebnet] OpenWebNetAuxiliaryHandler final adjustments' for Openha…

8a4b022

…b community testing (#11515) Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

[openwebnet] Fixes after first community testing (#11515)

2b8197a

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

[openwebnet] Fixes after final review (#11515)

d0194ef

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

[openwebnet] Fixes after second final review (#11515)

306c6ff

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

lolodomo requested changes May 5, 2022

View reviewed changes

fabgio added 2 commits May 8, 2022 10:50

[openwebnet] Fixes after third final review (#11515)

0347851

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

[openwebnet] Fixes after fourth final review (#11515)

46204e0

Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

lolodomo approved these changes May 8, 2022

View reviewed changes

lolodomo merged commit 888f962 into openhab:main May 8, 2022

lolodomo added this to the 3.3 milestone May 8, 2022

andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022

[openwebnet] Add support for sending Auxiliary (AUX) commands/message…

8ae841e

…s to the bus (WHO=9) (openhab#12468) Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023

[openwebnet] Add support for sending Auxiliary (AUX) commands/message…

552a994

…s to the bus (WHO=9) (openhab#12468) Signed-off-by: Giovanni Fabiani <fabiani.giovanni@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[openwebnet] Add support for sending Auxiliary (AUX) commands/messages to the bus (WHO=9) #12468

[openwebnet] Add support for sending Auxiliary (AUX) commands/messages to the bus (WHO=9) #12468

fabgio commented Mar 13, 2022 •

edited by mvalla

Loading

mvalla left a comment •

edited

Loading

mvalla commented Mar 19, 2022

fabgio commented Mar 22, 2022 via email •

edited by mvalla

Loading

mvalla commented Mar 22, 2022

fabgio commented Mar 27, 2022 •

edited

Loading

mvalla left a comment

fabgio commented Mar 31, 2022

openhab-bot commented Apr 17, 2022

mvalla commented Apr 19, 2022

mvalla left a comment •

edited

Loading

fabgio commented Apr 23, 2022

mvalla left a comment •

edited

Loading

mvalla commented Apr 24, 2022

mvalla commented May 4, 2022 •

edited

Loading

fabgio commented May 4, 2022

lolodomo left a comment

lolodomo left a comment

fabgio commented May 8, 2022

[openwebnet] Add support for sending Auxiliary (AUX) commands/messages to the bus (WHO=9) #12468

[openwebnet] Add support for sending Auxiliary (AUX) commands/messages to the bus (WHO=9) #12468

Conversation

fabgio commented Mar 13, 2022 • edited by mvalla Loading

Description

Test

mvalla left a comment • edited Loading

Choose a reason for hiding this comment

mvalla commented Mar 19, 2022

fabgio commented Mar 22, 2022 via email • edited by mvalla Loading

mvalla commented Mar 22, 2022

fabgio commented Mar 27, 2022 • edited Loading

mvalla left a comment

Choose a reason for hiding this comment

fabgio commented Mar 31, 2022

openhab-bot commented Apr 17, 2022

mvalla commented Apr 19, 2022

mvalla left a comment • edited Loading

Choose a reason for hiding this comment

fabgio commented Apr 23, 2022

mvalla left a comment • edited Loading

Choose a reason for hiding this comment

mvalla commented Apr 24, 2022

mvalla commented May 4, 2022 • edited Loading

fabgio commented May 4, 2022

lolodomo left a comment

Choose a reason for hiding this comment

lolodomo left a comment

Choose a reason for hiding this comment

fabgio commented May 8, 2022

fabgio commented Mar 13, 2022 •

edited by mvalla

Loading

mvalla left a comment •

edited

Loading

fabgio commented Mar 22, 2022 via email •

edited by mvalla

Loading

fabgio commented Mar 27, 2022 •

edited

Loading

mvalla left a comment •

edited

Loading

mvalla left a comment •

edited

Loading

mvalla commented May 4, 2022 •

edited

Loading