[icloud] Fix ONLINE state when device response status is 203 #12587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristof Rado <rado.krisi@gmail.com>
|
@pgfeller : is it ok for you? |
|
HTTP code 203 means the server response was updated by a proxy. This is not an error. |
|
@lolodomo yes if you treat it as an http response code then yes. |
|
@radokristof : as there is no feedback from the binding maintainer, let's go with the merge of your change. |
lolodomo
approved these changes
Apr 25, 2022
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
Signed-off-by: Kristof Rado <rado.krisi@gmail.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
Signed-off-by: Kristof Rado <rado.krisi@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
Signed-off-by: Kristof Rado <rado.krisi@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
Signed-off-by: Kristof Rado <rado.krisi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minor patch fixes an issue when the device response status code is 203.
This seems to work, but I don't know if this is enough/acceptable. Devices reports 203 status sometimes when they are online, sometimes when they are offline. However there seems to be another status code (201) for offline devices.
I couldn't find any info online what these status codes mean, nor any other reported value which can indicate the real status of an iCloud device.
Closes #12501