[yamahamusiccast] Fix VolumeDB channel resets on UDP event #12671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes [yamahamusiccast] VolumeDB channel resets to -80 on player channel change openhab#12656. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
jlaur
requested changes
May 1, 2022
...ccast/src/main/java/org/openhab/binding/yamahamusiccast/internal/YamahaMusiccastHandler.java
Outdated
Show resolved
Hide resolved
...ccast/src/main/java/org/openhab/binding/yamahamusiccast/internal/YamahaMusiccastHandler.java
Show resolved
Hide resolved
...ccast/src/main/java/org/openhab/binding/yamahamusiccast/internal/YamahaMusiccastHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.yamahamusiccast/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
@jlaur |
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…2671) * [yamahamusiccast] Fix VolumeDB resets on UDP event * [yamahamusiccast] Update channel description & docs Fixes [yamahamusiccast] VolumeDB channel resets to -80 on player channel change openhab#12656. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…2671) * [yamahamusiccast] Fix VolumeDB resets on UDP event * [yamahamusiccast] Update channel description & docs Fixes [yamahamusiccast] VolumeDB channel resets to -80 on player channel change openhab#12656. Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…2671) * [yamahamusiccast] Fix VolumeDB resets on UDP event * [yamahamusiccast] Update channel description & docs Fixes [yamahamusiccast] VolumeDB channel resets to -80 on player channel change openhab#12656. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a issue that was introduced by my PR #12519.
The recently added volume in dB channel resetted on UDP events that do not contain volume information due to a bug.
Fixes #12656.
@jlaur Maybe you could review?
Signed-off-by: Florian Hotze florianh_dev@icloud.com