[insteon] Ignore commands if device is not online #12787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
robnielsen
added
bug
|
@robnielsen - since not linked to any issue, can you add a description to this pull request? What is it solving, and what is the impact of the bug from user perspective? |
|
@jlaur, this was added as a defensive mechanism. The same change was added to the latest netatmo binding: https://github.com/openhab/openhab-addons/blob/main/bundles/org.openhab.binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/CommonInterface.java#L154 |
jlaur
changed the title
robnielsen
added a commit
to robnielsen/openhab-addons
that referenced
this pull request
May 24, 2022
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added as a defensive measure to ensure that commands are ignored if the device is offline.