Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[roku] Fix reporting of Roku Home app #12884

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Conversation

mlobstein
Copy link
Contributor

The '/query/active-app' endpoint now reports an id of 562859 instead of -1 when on the Roku Home screen. This change will revert the id back to -1 so that the Active App channel's drop down can correctly report when the Roku is on the home screen.

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein mlobstein added the bug An unexpected problem or unintended behavior of an add-on label Jun 4, 2022
@jlaur
Copy link
Contributor

jlaur commented Jun 4, 2022

@mlobstein - do you know why it reports this id? Is it documented? On which systems is it observed?

@mlobstein
Copy link
Contributor Author

@mlobstein - do you know why it reports this id? Is it documented? On which systems is it observed?

I just started integrating this binding into my setup (using a Roku Ultra) and noticed this today. I am assuming that this behavior started with the Roku v11.0.0 software which started going out to devices in late March of this year.

@jlaur
Copy link
Contributor

jlaur commented Jun 4, 2022

@mlobstein - do you know why it reports this id? Is it documented? On which systems is it observed?

I just started integrating this binding into my setup (using a Roku Ultra) and noticed this today. I am assuming that this behavior started with the Roku v11.0.0 software which started going out to devices in late March of this year.

Would it be possible to confirm this behavior and id from another Roku user? Asking because it seems strange, and I guess it's not impossible that something on your specific device is causing this?

@mlobstein
Copy link
Contributor Author

mlobstein commented Jun 5, 2022

Would it be possible to confirm this behavior and id from another Roku user? Asking because it seems strange, and I guess it's not impossible that something on your specific device is causing this?

I asked another user on the community for confirmation. Although after looking into it more I am pretty sure this is a new feature in Roku 11. When I check the '/query/media-player' end point while on the home screen, this is the response:
image

However, this app id is not reported in the installed app list:
image

I notice now that on the home screen there now appears an ad with a play button to play a preview of some content. I would surmise that this is the new "Roku Dynamic Menu" that replaced the original, non-dynamic one. But likely the original still exists for older devices that can't support the dynamic home screen. For the binding we need to support all permutations so adding this work-around is allow both versions of the home screen to be reported correctly in the Active App drop down.

@jlaur
Copy link
Contributor

jlaur commented Jun 6, 2022

@mlobstein - thanks for the explanation. To speed things up: Did you get confirmation from the user you asked?

@mlobstein
Copy link
Contributor Author

Did you get confirmation from the user you asked?

Yes another user also confirmed this behavior started recently:
https://community.openhab.org/t/roku-binding-power-for-tvs/136223/5

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/roku-binding-power-for-tvs/136223/7

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jlaur jlaur merged commit 22ebb98 into openhab:main Jun 6, 2022
@jlaur jlaur added this to the 3.3 milestone Jun 6, 2022
@mlobstein mlobstein deleted the roku_home_id branch June 6, 2022 14:22
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants