-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[roku] Fix reporting of Roku Home app #12884
Conversation
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein - do you know why it reports this id? Is it documented? On which systems is it observed? |
I just started integrating this binding into my setup (using a Roku Ultra) and noticed this today. I am assuming that this behavior started with the Roku v11.0.0 software which started going out to devices in late March of this year. |
Would it be possible to confirm this behavior and id from another Roku user? Asking because it seems strange, and I guess it's not impossible that something on your specific device is causing this? |
@mlobstein - thanks for the explanation. To speed things up: Did you get confirmation from the user you asked? |
Yes another user also confirmed this behavior started recently: |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/roku-binding-power-for-tvs/136223/7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
The '/query/active-app' endpoint now reports an id of 562859 instead of -1 when on the Roku Home screen. This change will revert the id back to -1 so that the Active App channel's drop down can correctly report when the Roku is on the home screen.