[openuv] Enhance server side error handling #12958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clinique <gael@lhopital.org>
clinique
added
the
enhancement
jlaur
requested changes
Jun 18, 2022
...ng.openuv/src/main/java/org/openhab/binding/openuv/internal/handler/OpenUVBridgeHandler.java
Outdated
Show resolved
Hide resolved
...ng.openuv/src/main/java/org/openhab/binding/openuv/internal/handler/OpenUVBridgeHandler.java
Outdated
Show resolved
Hide resolved
...ng.openuv/src/main/java/org/openhab/binding/openuv/internal/handler/OpenUVBridgeHandler.java
Outdated
Show resolved
Hide resolved
...ng.openuv/src/main/java/org/openhab/binding/openuv/internal/handler/OpenUVBridgeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: clinique <gael@lhopital.org>
lolodomo
reviewed
Jun 19, 2022
| scheduleReconnectJob(RECONNECT_DELAY_MIN); | ||
| } else { | ||
| statusDetail = ThingStatusDetail.NONE; | ||
| statusMessage = String.format("@text/offline.invalid-json [ \"%s\", \"%s\" ]", url, jsonData); |
There was a problem hiding this comment.
A relatively small message is expected (it will be displayed in UI). Is your jsonData small ?
If not, maybe you shoudl add a specific DEBUG log entry to log jsonData
There was a problem hiding this comment.
Size of invalid json is not easy to predict, so I take your proposal.
Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: clinique <gael@lhopital.org>
|
@jlaur : I let you check your comments and merge if this is ok |
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
* Enhance server side error handling * Enhancing exception tree * a small factorization of error status * Shorten statusMessage * Correcting log syntax Signed-off-by: clinique <gael@lhopital.org>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* Enhance server side error handling * Enhancing exception tree * a small factorization of error status * Shorten statusMessage * Correcting log syntax Signed-off-by: clinique <gael@lhopital.org>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* Enhance server side error handling * Enhancing exception tree * a small factorization of error status * Shorten statusMessage * Correcting log syntax Signed-off-by: clinique <gael@lhopital.org> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* Enhance server side error handling * Enhancing exception tree * a small factorization of error status * Shorten statusMessage * Correcting log syntax Signed-off-by: clinique <gael@lhopital.org>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* Enhance server side error handling * Enhancing exception tree * a small factorization of error status * Shorten statusMessage * Correcting log syntax Signed-off-by: clinique <gael@lhopital.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is aimed to solve issue #12932 .
It helps the binding auto reconnect on two known server issues, when db is not available, and when a good apikey fails due to....wrong behaviour of the server.
If these errors are detected, the bridge goes offline for five minutes, then tries to reconnect.
Signed-off-by: clinique gael@lhopital.org