Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arcam] Initial contribution #13302

Closed
wants to merge 5 commits into from

Conversation

joepadmiraal
Copy link
Contributor

@joepadmiraal joepadmiraal commented Aug 21, 2022

[Arcam] new binding

Initial contribution of the Arcam binding.

Description

This PR contains a new binding for the Arcam audio devices.
Currently the AVR and SA series of devices is supported.
It allows users to control and read status information from their Arcam amplifier.

I have tried to make the binding generic in order to prevent code duplication.
For this I have added a device specific class in the devices directory.
Unfortunately this is needed as each device has different capabilities and protocol nuances.
The protocol itself is a TCP based protocol and has different commands for the a single functionality, based on which device model you are communicating with.
The connection code contains retries etc. so temporarily connectivity issues will not break the binding.

Each device also has a ChannelTypeProvider which allows the binding to have device specific OptionChannels, for example showing only the inputs that are actually available on that specific device.

Discovery is done with UPnP.

Testing

This binding has been tested with the Arcam SA30

The jar can be downloaded here.

@joepadmiraal joepadmiraal requested a review from a team as a code owner August 21, 2022 14:38
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/unable-to-select-labels-on-github-in-addon-repository/138304/1

@lsiepel lsiepel added the new binding If someone has started to work on a binding. For a new binding PR. label Aug 21, 2022
@jlaur jlaur changed the title [arcam] New binding for Arcam audio devices [arcam] Initial contribution Aug 22, 2022
@joepadmiraal joepadmiraal force-pushed the arcam-squash branch 2 times, most recently from 6a88804 to 9be46db Compare September 8, 2022 20:10
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/arcam-binding/139287/1

Initial contribution of the Arcam binding.
Signed-off-by: Joep Admiraal <joep@groovytunes.nl>
Signed-off-by: joepadmiraal <joep@groovytunes.nl>
Signed-off-by: Joep Admiraal <joep@groovytunes.nl>
Signed-off-by: Joep Admiraal <joep@groovytunes.nl>
Signed-off-by: joepadmiraal <joep@groovytunes.nl>
Signed-off-by: Joep Admiraal <joep@groovytunes.nl>
Signed-off-by: Joep Admiraal <joep@groovytunes.nl>
Signed-off-by: joepadmiraal <joep@groovytunes.nl>
Signed-off-by: Joep Admiraal <joep@groovytunes.nl>
Signed-off-by: joepadmiraal <joep@groovytunes.nl>
Signed-off-by: Joep Admiraal <joep@groovytunes.nl>
Signed-off-by: joepadmiraal <joep@groovytunes.nl>
Signed-off-by: Joep Admiraal <joep@groovytunes.nl>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/arcam-binding-beta/139334/1

<parent>
<groupId>org.openhab.addons.bundles</groupId>
<artifactId>org.openhab.addons.reactor.bundles</artifactId>
<version>3.4.0-SNAPSHOT</version>
Copy link
Member

@wborn wborn Dec 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<version>3.4.0-SNAPSHOT</version>
<version>4.1.0-SNAPSHOT</version>

@@ -0,0 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be adapted to the new addon.xml, the PR to adapt the developer docs is not merged yet, so if you need more details, the corresponding issue is here: openhab/openhab-core#2058
But you can also update your branch and look at another binding's addon.xml and adapt it to this initial contribution.

@lsiepel
Copy link
Contributor

lsiepel commented Oct 15, 2023

@joepadmiraal do you still want to proceed with this pr?

@joepadmiraal
Copy link
Contributor Author

Hi @lsiepel

I am not actively using OpenHAB anymore and I think not a lot of users are using this addon.
So I think we should drop this PR unless you can see more than a few users are relying on it.

@lsiepel
Copy link
Contributor

lsiepel commented Nov 7, 2023

Hi @lsiepel

I am not actively using OpenHAB anymore and I think not a lot of users are using this addon. So I think we should drop this PR unless you can see more than a few users are relying on it.

Thanks for the reply. As this binding has not been part of openHAB yet, I don’t think there will be any active users. If you abandon this PR i think it is better to close this. If ever needed it can be tracked and code can be re-used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants