[Konnected] Removed defaults for zone configuration parameter from the channels #13333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haavar Valeur <haavar@haavar.com>
|
@haavar - should this now be mentioned in the README? Since now required, I would assume it would need to be included in full example as bare minimum? https://next.openhab.org/addons/bindings/konnected/#full-example |
Signed-off-by: Haavar Valeur <haavar@haavar.com>
I read though the readme, and I did not see anything that would need to be updated because of this change. I did however notice that the example config used the wrong property name for the zone. I updated that. |
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Sep 3, 2022
…e channels (openhab#13333) * Removed defaults from zone parameter * Corrected the name of the zone property in example Signed-off-by: Haavar Valeur <haavar@haavar.com>
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
…e channels (openhab#13333) * Removed defaults from zone parameter * Corrected the name of the zone property in example Signed-off-by: Haavar Valeur <haavar@haavar.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…e channels (openhab#13333) * Removed defaults from zone parameter * Corrected the name of the zone property in example Signed-off-by: Haavar Valeur <haavar@haavar.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…e channels (openhab#13333) * Removed defaults from zone parameter * Corrected the name of the zone property in example Signed-off-by: Haavar Valeur <haavar@haavar.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
marcelGoerentz
pushed a commit
to marcelGoerentz/openhab-addons
that referenced
this pull request
Nov 14, 2022
…e channels (openhab#13333) * Removed defaults from zone parameter * Corrected the name of the zone property in example Signed-off-by: Haavar Valeur <haavar@haavar.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…e channels (openhab#13333) * Removed defaults from zone parameter * Corrected the name of the zone property in example Signed-off-by: Haavar Valeur <haavar@haavar.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…e channels (openhab#13333) * Removed defaults from zone parameter * Corrected the name of the zone property in example Signed-off-by: Haavar Valeur <haavar@haavar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for issue when adding channels with the default zone configured. The thing get into an invalid config state when adding a channel with the default zone selected. The only way to add channel for the default zone is to add a channel for a different zone, then go back and edit it to the default value.
The cause is that the zone parameter was marked as required and had a default.
The default value did not make sense to me, so I removed it.