[Konnected] Configure zone on panel even if the channel is not yet linked #13380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haavar Valeur <haavar@haavar.com>
lolodomo
approved these changes
Sep 17, 2022
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
…b#13380) Signed-off-by: Haavar Valeur <haavar@haavar.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…b#13380) Signed-off-by: Haavar Valeur <haavar@haavar.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…b#13380) Signed-off-by: Haavar Valeur <haavar@haavar.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…b#13380) Signed-off-by: Haavar Valeur <haavar@haavar.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…b#13380) Signed-off-by: Haavar Valeur <haavar@haavar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change the binding would only send the zone configuration to the panel if the channel for that zone was linked to an item. This would cause the settings pushed on the creation of a new channel to not contain the new channel. Settings are not pushed when channels are linked. The result is that zones may or may not be correctly provisioned.
This change remove the check to see if a channel is linked before provisioning the zone.
The diff looks bigger than what it is. It's mostly just changing the indentation after removing the conditional.