Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[homekit] get min/max/step values from state description if possible #13510

Merged
merged 1 commit into from Oct 9, 2022
Merged

[homekit] get min/max/step values from state description if possible #13510

merged 1 commit into from Oct 9, 2022

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Oct 7, 2022

this helps to auto-configure if the binding is providing the necessary info

metadata config still overrides

@ccutrer
[homekit] get min/max/step values from state description if possible
9eabeba 
this helps to auto-configure if the binding is providing the necessary info

metadata config still overrides

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@lolodomo lolodomo added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Oct 8, 2022
@lolodomo
Copy link
Contributor

lolodomo commented Oct 9, 2022

@yfre : maybe you can make a first review

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Oct 9, 2022
yfre
yfre approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@yfre yfre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yfre
Copy link
Contributor

yfre commented Oct 9, 2022

@ccutrer thank you
good idea. we should reduce the need of double configuration. if we can get something from semantic model we should use it.
good, that one can overwrite the model settings for homekit.

lolodomo
lolodomo approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 0aa28e5 into openhab:main Oct 9, 2022
@lolodomo lolodomo added this to the 3.4 milestone Oct 9, 2022
@ccutrer ccutrer deleted the homekit-min-max-from-state-description branch October 11, 2022 22:09
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@ccutrer @andan67
[homekit] get min/max/step values from state description if possible (o…
3353002 
…penhab#13510)

this helps to auto-configure if the binding is providing the necessary info

metadata config still overrides

Signed-off-by: Cody Cutrer <cody@cutrer.us>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@ccutrer @andrasU
[homekit] get min/max/step values from state description if possible (o…
4c54494 
…penhab#13510)

this helps to auto-configure if the binding is providing the necessary info

metadata config still overrides

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
@ccutrer @borazslo
[homekit] get min/max/step values from state description if possible (o…
793b848 
…penhab#13510)

this helps to auto-configure if the binding is providing the necessary info

metadata config still overrides

Signed-off-by: Cody Cutrer <cody@cutrer.us>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@ccutrer @psmedley
[homekit] get min/max/step values from state description if possible (o…
398a352 
…penhab#13510)

this helps to auto-configure if the binding is providing the necessary info

metadata config still overrides

Signed-off-by: Cody Cutrer <cody@cutrer.us>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@ccutrer @nemerdaud
[homekit] get min/max/step values from state description if possible (o…
b69f004 
…penhab#13510)

this helps to auto-configure if the binding is providing the necessary info

metadata config still overrides

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@yfre yfre yfre approved these changes

@andylintner andylintner Awaiting requested review from andylintner andylintner is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ccutrer @lolodomo @yfre