[homekit] increase flexibility of ColorTemperature #13538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow Number or Dimmer items, and mired or Kelvin units. Signed-off-by: Cody Cutrer <cody@cutrer.us>
wborn
added
awaiting other PR
|
fixes #12517 |
wborn
added
rebuild
|
@yfre : this is ready for review now; the openhab-core dependencies have been merged. |
yfre
reviewed
Oct 20, 2022
| final int finalMinValue = minValue; | ||
| final int range = maxValue - minValue; | ||
|
|
||
| // final int defaultValue = minValue; |
There was a problem hiding this comment.
this commented out line can be probably removed
Signed-off-by: Cody Cutrer <cody@cutrer.us>
An invertible unit is simply a conversion that allows changing dimensions. This is required because mired is 1/K (plus a multiplication), and that's technically a different dimension (of 1/temperature, not temperature). It's a new concept introduced into core for this. I need to do a PR for the MQTT binding that uses it to allow implicit conversion between K<->Mired with that binding as well. |
lolodomo
reviewed
Oct 21, 2022
.../src/main/java/org/openhab/io/homekit/internal/accessories/HomekitCharacteristicFactory.java
Show resolved
Hide resolved
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* [homekit] increase flexibility of ColorTemperature allow Number or Dimmer items, and mired or Kelvin units. Signed-off-by: Cody Cutrer <cody@cutrer.us>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* [homekit] increase flexibility of ColorTemperature allow Number or Dimmer items, and mired or Kelvin units. Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo
pushed a commit
to borazslo/openhab-mideaac-addon
that referenced
this pull request
Jan 8, 2023
* [homekit] increase flexibility of ColorTemperature allow Number or Dimmer items, and mired or Kelvin units. Signed-off-by: Cody Cutrer <cody@cutrer.us>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* [homekit] increase flexibility of ColorTemperature allow Number or Dimmer items, and mired or Kelvin units. Signed-off-by: Cody Cutrer <cody@cutrer.us>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* [homekit] increase flexibility of ColorTemperature allow Number or Dimmer items, and mired or Kelvin units. Signed-off-by: Cody Cutrer <cody@cutrer.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow Number or Dimmer items, and mired or Kelvin units.
Dependent on openhab/openhab-core#3108 and hap-java/HAP-Java#167