New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[voskstt] Fix load on linux arm #13556
Conversation
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
After an update of the bundle, a clean of
|
Hi @lolodomo, a little update from my side. Not sure if something can be done in the binding to load this shared library using java before the first call to vosk or if is better to report the issue in the vosk repo. I'm afraid I have not enough knowledge about c :S I will do more investigation later or tomorrow about how it can be fixed. Let me know if you have any advise or if you can confirm that workaround works for you. |
Do not test the workaround, I was able to load the library from the binding, I'll update the pr! |
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
This last version works fine for me, only requirement is have libatomic installed. |
Please update README to mention the prerequisite and how to install the missing library. |
|
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to update the library finally?
...g.openhab.voice.voskstt/src/main/java/org/openhab/voice/voskstt/internal/VoskSTTService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
No I checked it agains and outdated branch, the binary was correctly downloaded. Once I merge master to this branch that change was the same, also the call to 'LibVosk.setLogLevel(LogLevel.WARNINGS);' was missed in this branch, that is why it failed different earlier. The problem was always the missing libatomic library. Sorry for the whole confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
After installing snapshot 3143, I can tell you that I have no warning/error in logs at startup. |
Thank you for the confirmation, in my tests I enabled the model load and it works without errors, so I think it will work well.
|
Confirmed, the file already exists in my system (RPI3). |
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Try to fix error on armv7.
Signed-off-by: Miguel Álvarez miguelwork92@gmail.com