[bluetooth] Null annotations and SAT #13967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
|
I do have some questions. This and the related bluetooth bindings have warnings about the bridge id. I don;t understand why this is in place. So maybe someone can point me in the right direction, if this is fixable or not. Also the BluetoothDiscoveryService.java shows some null pointer related issues i find hard to addres without making the code sloppy and unreadable. Hopefully someone can point me in the right direction. The build fails, the needed change in bluetooth.bluegiga has allready been prepared. |
lsiepel
added
awaiting other PR
lsiepel
added
the
additional testing preferred
lsiepel
added
rebuild
kaikreuzer
approved these changes
Mar 6, 2023
kaikreuzer
removed
the
additional testing preferred
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
* null annotation, checkstyle, dependency Signed-off-by: Leo Siepel <leosiepel@gmail.com>
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
* null annotation, checkstyle, dependency Signed-off-by: Leo Siepel <leosiepel@gmail.com>
jlaur
pushed a commit
to jlaur/openhab-addons
that referenced
this pull request
Jul 28, 2023
Fixes openhab#15313 Partially reverts openhab#13967 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
pushed a commit
to jlaur/openhab-addons
that referenced
this pull request
Jul 28, 2023
Fixes openhab#15313 Partially reverts openhab#13967 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
added a commit
to jlaur/openhab-addons
that referenced
this pull request
Jul 28, 2023
Fixes openhab#15313 Partially reverts openhab#13967 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
kaikreuzer
pushed a commit
that referenced
this pull request
Jul 28, 2023
kaikreuzer
pushed a commit
that referenced
this pull request
Jul 28, 2023
Merged
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
Fixes openhab#15313 Partially reverts openhab#13967 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This and some more PR's to follow focus on reducing the SAT warnings and add null annotations to the set of bluetooth bindings. While doing so i tried to change as less as possible to the inner workings as it is a complex set.
Hopefully some (not yet) bugs are fixed in advance and no new ones are introduced.
Depends on #13974