Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TapoControl] Add P300 to the list of supported equipments #14364

Merged
merged 4 commits into from Feb 14, 2023

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Feb 8, 2023

No description provided.

Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique self-assigned this Feb 9, 2023
@clinique clinique added the enhancement An enhancement or new feature for an existing add-on label Feb 9, 2023
@clinique clinique added this to the 4.0 milestone Feb 9, 2023
@jlaur jlaur removed this from the 4.0 milestone Feb 9, 2023
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the P300! I have provided feedback in the form of some minor comments.

Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: clinique <gael@lhopital.org>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 7820c2d into openhab:main Feb 14, 2023
@jlaur jlaur added this to the 4.0 milestone Feb 14, 2023
@clinique clinique deleted the P300 branch February 14, 2023 12:00
SMHRambo pushed a commit to SMHRambo/openhab-addons that referenced this pull request Feb 14, 2023
…b#14364)

* Adding P300 to the list of supported equipments

Signed-off-by: clinique <gael@lhopital.org>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
…b#14364)

* Adding P300 to the list of supported equipments

Signed-off-by: clinique <gael@lhopital.org>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
…b#14364)

* Adding P300 to the list of supported equipments

Signed-off-by: clinique <gael@lhopital.org>
@jlaur jlaur changed the title [TapoControl] Adding P300 to the list of supported equipments [TapoControl] Add P300 to the list of supported equipments Apr 1, 2023
@jlaur jlaur linked an issue Apr 1, 2023 that may be closed by this pull request
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
…b#14364)

* Adding P300 to the list of supported equipments

Signed-off-by: clinique <gael@lhopital.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TapoControl] Add support for P300 smart power strip
2 participants