New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TapoControl] Add P300 to the list of supported equipments #14364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: clinique <gael@lhopital.org>
clinique
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Feb 9, 2023
jlaur
requested changes
Feb 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the P300! I have provided feedback in the form of some minor comments.
...ocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/api/TapoDeviceConnector.java
Outdated
Show resolved
Hide resolved
...ocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/api/TapoDeviceConnector.java
Outdated
Show resolved
Hide resolved
...rol/src/main/java/org/openhab/binding/tapocontrol/internal/constants/TapoThingConstants.java
Outdated
Show resolved
Hide resolved
...ontrol/src/main/java/org/openhab/binding/tapocontrol/internal/structures/TapoSubRequest.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/thing/P300.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/thing/channels.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: clinique <gael@lhopital.org>
jlaur
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SMHRambo
pushed a commit
to SMHRambo/openhab-addons
that referenced
this pull request
Feb 14, 2023
…b#14364) * Adding P300 to the list of supported equipments Signed-off-by: clinique <gael@lhopital.org>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…b#14364) * Adding P300 to the list of supported equipments Signed-off-by: clinique <gael@lhopital.org>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
…b#14364) * Adding P300 to the list of supported equipments Signed-off-by: clinique <gael@lhopital.org>
jlaur
changed the title
[TapoControl] Adding P300 to the list of supported equipments
[TapoControl] Add P300 to the list of supported equipments
Apr 1, 2023
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
…b#14364) * Adding P300 to the list of supported equipments Signed-off-by: clinique <gael@lhopital.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.