Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[phc] Remove import org.apache.common #14422

Merged
merged 2 commits into from
Feb 19, 2023
Merged

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Feb 17, 2023

  • Remove dependency on apache.commons

Provided some tests for the padding, rest is untested, minor refactoring from only from code perspective

Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel changed the title [phc] import org.apache.common [phc] Remove import org.apache.common Feb 18, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit d168d04 into openhab:main Feb 19, 2023
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Feb 19, 2023
@lolodomo lolodomo added this to the 4.0 milestone Feb 19, 2023
@lsiepel lsiepel deleted the phc-apache branch February 19, 2023 20:42
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
@jlaur jlaur removed the enhancement An enhancement or new feature for an existing add-on label Mar 10, 2023
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants