Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sensibo] Remove org.apache.common #14434

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Feb 18, 2023

  • Remove dependency on apache.commons

Created some tests, not all is tested, minor refactoring from code perspective

Signed-off-by: lsiepel <leosiepel@gmail.com>
Copy link
Contributor

@seime seime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the comment, otherwise LGTM

@lsiepel lsiepel requested a review from a team April 6, 2023 19:36
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit 46a73be into openhab:main Apr 6, 2023
@jlaur jlaur added this to the 4.0 milestone Apr 6, 2023
@lsiepel lsiepel deleted the sensibo-apache branch April 7, 2023 06:15
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants