Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imperihome] Remove org.apache.common #14441

Merged
merged 2 commits into from
Feb 19, 2023
Merged

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Feb 18, 2023

  • Remove dependency on org.apache.commons

Untested, minor refactoring only from code perspective

Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: lsiepel <leosiepel@gmail.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Feb 19, 2023
@lolodomo lolodomo merged commit 9828daf into openhab:main Feb 19, 2023
@lolodomo lolodomo added this to the 4.0 milestone Feb 19, 2023
@lsiepel lsiepel deleted the imperihome-apache branch February 19, 2023 20:06
@jlaur
Copy link
Contributor

jlaur commented Feb 22, 2023

@lolodomo - I don't think we should have "enhancement" label on these PR's since it's purely technical refactoring? With this label in will be mentioned in release notes.

@lolodomo
Copy link
Contributor

I think it is good to have any code change in the release notes. It can help users identifying what changes could have broken something.

@lsiepel
Copy link
Contributor Author

lsiepel commented Feb 22, 2023

Are you sure? As that does not seem to be common practice in the past: https://github.com/openhab/openhab-addons/pulls?page=2&q=is%3Apr+is%3Aclosed+no%3Alabel many technicall code changes without tags

@jlaur
Copy link
Contributor

jlaur commented Feb 22, 2023

I think it is good to have any code change in the release notes. It can help users identifying what changes could have broken something.

I don't think that has been common until now, but of course there can be gray areas where we need to assess individually whether to mention or not. My impression so far has been not to mention small purely technical refactoring PR's (without expected user impact). @openhab/add-ons-maintainers, any opinions to have some common ground, so we don't continuously add/remove labels based on different rules?

nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants