New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jrubyscripting] Update README, and default configuration installing gem #14489
[jrubyscripting] Update README, and default configuration installing gem #14489
Conversation
Because the addon will [install the gem by default](openhab/openhab-addons#14489), remove the instructions to configure it from the installation instructions. Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
91ffea2
to
9985e88
Compare
This is ready for review. The 5.0.0 gem isn't published yet, but it will be in the next 48 hours, and there will be no more changes to its USAGE.md. |
5.0.0 of the gem as been released |
@openhab/add-ons-maintainers this should also be included into M1 along with #14556 |
bundles/org.openhab.automation.jrubyscripting/src/main/resources/OH-INF/config/config.xml
Show resolved
Hide resolved
d2d6d8c
to
8fb7b47
Compare
README is generated by YARD from USAGE.md in the gem. Signed-off-by: Cody Cutrer <cody@cutrer.us>
8fb7b47
to
5adb8bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-4-0-snapshot-discussion/142322/254 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
…gem (openhab#14489) README is generated by YARD from USAGE.md in the gem. Signed-off-by: Cody Cutrer <cody@cutrer.us>
README is generated by YARD from USAGE.md in the gem.