Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jrubyscripting] Update README, and default configuration installing gem #14489

Merged
merged 1 commit into from Mar 27, 2023

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Feb 23, 2023

README is generated by YARD from USAGE.md in the gem.

@ccutrer ccutrer marked this pull request as draft February 23, 2023 19:37
ccutrer pushed a commit to openhab/openhab-jruby that referenced this pull request Mar 1, 2023
Because the addon will [install the gem by
default](openhab/openhab-addons#14489), remove
the instructions to configure it from the installation instructions.

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@ccutrer ccutrer force-pushed the jrubyscripting-readme-and-default-gem branch from 91ffea2 to 9985e88 Compare March 2, 2023 15:36
@ccutrer ccutrer marked this pull request as ready for review March 8, 2023 15:55
@ccutrer
Copy link
Contributor Author

ccutrer commented Mar 8, 2023

This is ready for review. The 5.0.0 gem isn't published yet, but it will be in the next 48 hours, and there will be no more changes to its USAGE.md.

@ccutrer
Copy link
Contributor Author

ccutrer commented Mar 8, 2023

5.0.0 of the gem as been released

@jimtng
Copy link
Contributor

jimtng commented Mar 8, 2023

@openhab/add-ons-maintainers this should also be included into M1 along with #14556

@ccutrer ccutrer force-pushed the jrubyscripting-readme-and-default-gem branch from d2d6d8c to 8fb7b47 Compare March 9, 2023 15:42
README is generated by YARD from USAGE.md in the gem.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer ccutrer force-pushed the jrubyscripting-readme-and-default-gem branch from 8fb7b47 to 5adb8bd Compare March 9, 2023 15:46
Copy link
Contributor

@jimtng jimtng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-0-snapshot-discussion/142322/254

@wborn wborn changed the title [jrubyscripting] update README, and default configuration installing gem [jrubyscripting] Update README, and default configuration installing gem Mar 17, 2023
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@jlaur jlaur merged commit 558908e into openhab:main Mar 27, 2023
2 checks passed
@jlaur jlaur added this to the 4.0 milestone Mar 27, 2023
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
…gem (openhab#14489)

README is generated by YARD from USAGE.md in the gem.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer ccutrer deleted the jrubyscripting-readme-and-default-gem branch November 29, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants