[kaleidescape] Remove Apache StringEscapeUtils #14513
Conversation
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
There was a problem hiding this comment.
The code looks good. Only thing is, i can't tell if it handles all required cases. StringEscapeUtils.unescapeHtml4 handles ~290 different cases.
It would be really helpfull if a unit test was provided. Throwing in some examples into the stringformatter method.
|
IIRC we use unbescape in other add-ons |
And we try to get rid of them. Would be nice to have such a utility function in core. Please see #7722 (comment) |
|
If you scroll up in that issue, you can see that this es exactly the reason why we introduced unbescape. It‘s hard to get it right. |
Totally agree, unbescape got somewhat burried in that topic. i re-read and allready got a PR for BSBLAN with that dependency. Would be nice if someone could have commented in that topic about my30+ PR's though. Regarding this PR, if all works as expected i would opt to merge it as is without any additional dependency, but it's not up to me. |
|
I added some tests. This implementation only needs to un-escape the Latin-1 characters as described in the protocol reference manual: |
* Remove Apache StringEscapeUtils * add tests Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Replace StringEscapeUtils.unescapeHtml4() with basic Java methods to address #7722. Also a couple very minor tweaks that I have had pending for some time now.