[actiontemplatehli] Simplify usage and add UI #14647
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
|
Some ui recodings:
|
|
@lolodomo probably still a lot of room for improvement but I think its a bit easier to use now. |
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
GiviMAD
force-pushed
the
actiontemplatehli/simplify_usage
branch
from
eb26e10
to
30d19ec
Compare
jlaur
changed the title
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/actiontemplateinterpreter-next-3-4-0-4-0-0/142036/1 |
|
Another option, which will avoid the having a separate UI, can be create things that represent the actions that way the configuration can be done using the main UI. Also after reading @dalgwen idea of adding an intent catalog, maybe is easier to remove all the target configuration from the actions and link them to the items using a metadata tag. If someone have some feedback about it, please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rework of this add-on.
Mayor difference is that it stops requiring file system configurations as it includes a small UI to configure the interpreter actions.
This UI is developed with a minimum amount of dependencies thinking on avoiding as much maintenance work as posible in the future. Still I used typescript and vite for the building process, axios and pkce-challenge (for supporting the authentication workflow), and also picocss to have some predefined styles.
Also there are some minor structure changes, now actions can target multiple item types and be restricted by its semantic and/or tags.