[modbus] Re-enable itests after core change #15017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
jlaur
changed the title
tb4jc
pushed a commit
to tb4jc/openhab-addons
that referenced
this pull request
Jun 19, 2023
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Aug 9, 2023
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds for #15010 somehow do not complete. This is a try to do it separately.
Re-enable itests for modbus.
After core change
CoreItemFactoryctor requires aUnitProvider.From itests the class
TestUnitProvideris not visible, so I tried a mockup.Jenkins results need to be reviewed.