[mqtt.ruuvigateway] Re-enable itests after core change #15018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborn
reviewed
May 23, 2023
holgerfriedrich
changed the title
|
@holgerfriedrich, @lolodomo just FYI, it seems that #14970 caused #15019 to fail? |
Sorry, apparently I'm mistaking mqtt.ruuvigateway and mqtt.espmilighthub. |
holgerfriedrich
force-pushed
the
pr-itests2
branch
from
280a328
to
4995394
Compare
holgerfriedrich
force-pushed
the
pr-itests2
branch
from
2e026ee
to
330b72d
Compare
holgerfriedrich
force-pushed
the
pr-itests2
branch
from
330b72d
to
76c855a
Compare
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
|
@holgerfriedrich I just pushed a small addition to your branch. Is that ok with you? |
|
@J-N-K thanks! I could not make it work with the CI, now the test seems fine. |
jlaur
reviewed
Jul 17, 2023
...ruuvigateway.tests/src/main/java/org/openhab/binding/mqtt/ruuvigateway/RuuviGatewayTest.java
Outdated
Show resolved
Hide resolved
jlaur
reviewed
Jul 17, 2023
...ruuvigateway.tests/src/main/java/org/openhab/binding/mqtt/ruuvigateway/RuuviGatewayTest.java
Outdated
Show resolved
Hide resolved
mvn spotless:apply -Dspotless.eclipse.version=4.25 Signed-off-by: Wouter Born <github@maindrain.net>
J-N-K
approved these changes
Jul 17, 2023
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
Also-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds for #15010 somehow do not complete. This is a try to do it separately.
Re-enable itests for mqtt.ruuvigateway.
After core change
CoreItemFactoryctor requires aUnitProvider.From itests the class
TestUnitProvideris not visible, so I tried a mockup.Jenkins results need to be reviewed.