Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dsmr] Add support for capacity tariff for Belgium #15038

Merged
merged 9 commits into from Mar 12, 2024
Merged

Conversation

coop-git
Copy link
Contributor

Title

Added capacity tariff for Belgium

Description

Last year the capacity tariff was introduced in Belgium. Per quarter it will calculate your maximum demand from the grid.
And of course, you will pay based on this demand.
I added 2 channels to know what is the current capacity demand and the highest, current capacity peak of the month.
Via these values you can steer your consumption.

Signed-off-by: Lennert Coopman <github@coopman.org>
@coop-git coop-git requested a review from Hilbrand as a code owner May 28, 2023 12:08
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/dsmr-binding-suitable-for-belgium-smart-meters/89677/74

@jlaur jlaur changed the title Added support for capacity tariff for Belgium [dsmr] Add support for capacity tariff for Belgium May 28, 2023
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label May 28, 2023
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the new channels to the README.md.

Comment on lines 39 to 40
<channel id="emeter_actual_demand" typeId="actualDeliveryType"/>
<channel id="emeter_maximum_demand_current_month" typeId="actualDeliveryType"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should create a specific channel type in the channeltypes_electricity.xml. The way it's done here means in the user interface the user will see 3 times the same channel label and not be able to distinguish from the label what the channel is for.

Also put the channels in logical position in the list of channels, and not just add them add the end of the list of channels. For example after the emeter_actual_production channel.

The emeter_maximum_demand_current_month also as a timestamp. You could also add this as a channel. (Same channel name with _timestamp appended: emeter_maximum_demand_current_month_timestamp)

coop-git and others added 2 commits November 5, 2023 09:56
Signed-off-by: Lennert Coopman <github@coopman.org>
@lsiepel
Copy link
Contributor

lsiepel commented Feb 10, 2024

Gentle ping @coop-git can you proceed with this PR?

@kimdeschutter
Copy link

Hello, any idea when this request will be implemented?

@lsiepel
Copy link
Contributor

lsiepel commented Mar 10, 2024

Hello, any idea when this request will be implemented?

As soon as @coop-git is able to address the review comments we can proceed.

coop-git and others added 5 commits March 10, 2024 18:03
…ng/meter_electricity_emucs_v1_0.xml

Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Signed-off-by: coop-git <65073745+coop-git@users.noreply.github.com>
Signed-off-by: Lennert Coopman <github@coopman.org>
Signed-off-by: Lennert Coopman <github@coopman.org>
@coop-git
Copy link
Contributor Author

@lsiepel @kimdeschutter Accepted the proposal and committed the changes. Hopefully this is good enough to continue with the merge. Other changes can be done later where needed.
Thanks for being patient.

Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel merged commit 7dfebd6 into openhab:main Mar 12, 2024
3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Mar 12, 2024
@dequeckerp
Copy link

Just tested it in 4.2.0-SNAPSHOT and the "Actual Power Delivery" channel is shown twice in the UI.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants