Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[km200] Fix support for older MB-LAN (=KM200, version 1.0) by avoiding query of an unsupported attribute. #15070

Merged
merged 1 commit into from Jun 11, 2023

Conversation

gs4711
Copy link
Contributor

@gs4711 gs4711 commented Jun 9, 2023

Fixed support for MB-LAN (=KM200, version 1.0) by avoiding query of an unsupported attribute.

The oldest device seems to cause some trouble for this binding as it queries the attribute /gateway/registrations, which leads to an inconsistency in the gateway answers. This prevents the binding to move forward into the initialized mode.

Solving the old bug report.

@gs4711 gs4711 requested a review from Markinus as a code owner June 9, 2023 10:42
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Jun 9, 2023
@jlaur jlaur changed the title [KM200] Bugfix - support for older MB-LAN (=KM200, version 1.0) by avoiding query of an unsupported attribute. [KM200] Fix support for older MB-LAN (=KM200, version 1.0) by avoiding query of an unsupported attribute. Jun 9, 2023
@jlaur jlaur changed the title [KM200] Fix support for older MB-LAN (=KM200, version 1.0) by avoiding query of an unsupported attribute. [km200] Fix support for older MB-LAN (=KM200, version 1.0) by avoiding query of an unsupported attribute. Jun 9, 2023
- Fixed support for MB-LAN (=KM200, version 1.0) by avoiding query of an unsupported attribute.
- BEFORE this fix: The MBLAN does not support the /gateway/registrations attribute and returns an invalid answer:
*   [b.binding.km200.internal.KM200Device] - /gateway/registrations: trying to query information.
*   [b.binding.km200.internal.KM200Device] - /gateway/registrations: trying to decode: [B@4de25f6.
*   [binding.km200.internal.KM200Cryption] - Length of message is 11.
*   [binding.km200.internal.KM200Cryption] - Did NOT decrypt message
*   [binding.km200.internal.KM200Cryption] - Exception on encoding

    Signed-off-by: guenther.schreiner@smile.de

Logging of detailed error message.
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/buderus-km200-binding-firmware-04-08-02-initializing-error/136637/15

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/km200-km50-100-200-gateway-uninitialized-handler-initializing-error/107615/6

Copy link
Contributor

@Markinus Markinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit db01324 into openhab:main Jun 11, 2023
3 checks passed
@jlaur jlaur added this to the 4.0 milestone Jun 11, 2023
tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
…15070)

- Fixed support for MB-LAN (=KM200, version 1.0) by avoiding query of an unsupported attribute.
- BEFORE this fix: The MBLAN does not support the /gateway/registrations attribute and returns an invalid answer:
*   [b.binding.km200.internal.KM200Device] - /gateway/registrations: trying to query information.
*   [b.binding.km200.internal.KM200Device] - /gateway/registrations: trying to decode: [B@4de25f6.
*   [binding.km200.internal.KM200Cryption] - Length of message is 11.
*   [binding.km200.internal.KM200Cryption] - Did NOT decrypt message
*   [binding.km200.internal.KM200Cryption] - Exception on encoding

Logging of detailed error message.

Signed-off-by: guenther.schreiner@smile.de
Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
…15070)

- Fixed support for MB-LAN (=KM200, version 1.0) by avoiding query of an unsupported attribute.
- BEFORE this fix: The MBLAN does not support the /gateway/registrations attribute and returns an invalid answer:
*   [b.binding.km200.internal.KM200Device] - /gateway/registrations: trying to query information.
*   [b.binding.km200.internal.KM200Device] - /gateway/registrations: trying to decode: [B@4de25f6.
*   [binding.km200.internal.KM200Cryption] - Length of message is 11.
*   [binding.km200.internal.KM200Cryption] - Did NOT decrypt message
*   [binding.km200.internal.KM200Cryption] - Exception on encoding

Logging of detailed error message.

Signed-off-by: guenther.schreiner@smile.de
Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
…15070)

- Fixed support for MB-LAN (=KM200, version 1.0) by avoiding query of an unsupported attribute.
- BEFORE this fix: The MBLAN does not support the /gateway/registrations attribute and returns an invalid answer:
*   [b.binding.km200.internal.KM200Device] - /gateway/registrations: trying to query information.
*   [b.binding.km200.internal.KM200Device] - /gateway/registrations: trying to decode: [B@4de25f6.
*   [binding.km200.internal.KM200Cryption] - Length of message is 11.
*   [binding.km200.internal.KM200Cryption] - Did NOT decrypt message
*   [binding.km200.internal.KM200Cryption] - Exception on encoding

Logging of detailed error message.

Signed-off-by: guenther.schreiner@smile.de
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants