Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opengarage] Add support for vehicle status not available #15080

Merged
merged 1 commit into from Jun 11, 2023

Conversation

hunzinker
Copy link
Contributor

[opengarage] Add support for vehicle status not available.

Description

The current implementation logs vehicle status of 3 as a WARN. This PR proposes we change the behavior and support not available which is inline with the OpenGarage firmware.

I believe this change is an improvement. Thanks for all of the great work on openHAB!

Tests

N/A - this add-on does not have tests.

Signed-Off-By: Ken Seal <hunzinker@gmail.com>
@hunzinker hunzinker requested a review from psmedley as a code owner June 10, 2023 23:09
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@J-N-K J-N-K added the enhancement An enhancement or new feature for an existing add-on label Jun 11, 2023
@J-N-K J-N-K added this to the 4.0 milestone Jun 11, 2023
@J-N-K J-N-K merged commit 5e1c9e8 into openhab:main Jun 11, 2023
3 checks passed
@jlaur jlaur changed the title [opengarage] Add support for vehicle status not available. [opengarage] Add support for vehicle status not available Jun 11, 2023
tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
Signed-off-by: Ken Seal <hunzinker@gmail.com>
Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
Signed-off-by: Ken Seal <hunzinker@gmail.com>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Ken Seal <hunzinker@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants