Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[renault] Add support for MyDacia accounts and Dacia Spring car #15101

Merged
merged 6 commits into from Jun 17, 2023

Conversation

dougculnane
Copy link
Contributor

@dougculnane dougculnane commented Jun 17, 2023

This PR adds an "Account Type" configuration option so that uses can select (the non-default) type for MyDacia Cars. Request for this enhancement was made here: #14227

@dougculnane dougculnane added the enhancement An enhancement or new feature for an existing add-on label Jun 17, 2023
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please generate the I18N properties file to get the new strings included.

@jlaur jlaur changed the title [renault] Support for MyDacia accounts and Dacia Spring car #14227 [renault] Add support for MyDacia accounts and Dacia Spring car Jun 17, 2023
dougculnane and others added 2 commits June 17, 2023 12:25
…thing/thing-types.xml

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Doug Culnane <32482395+dougculnane@users.noreply.github.com>
Signed-off-by: Doug Culnane <doug@culnane.net>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dougculnane
Copy link
Contributor Author

Thanks! Please generate the I18N properties file to get the new strings included.

@jlaur Thanks for the quick review.
I did a mvn i18n:generate-default-translations and pushed changes.

@jlaur jlaur merged commit ff9254d into openhab:main Jun 17, 2023
3 checks passed
@jlaur jlaur added this to the 4.0 milestone Jun 17, 2023
@jlaur jlaur linked an issue Jun 17, 2023 that may be closed by this pull request
tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
…hab#15101)

* [renault] Support for MyDacia accounts and Dacia Spring car

Signed-off-by: Doug Culnane <doug@culnane.net>
Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
…hab#15101)

* [renault] Support for MyDacia accounts and Dacia Spring car

Signed-off-by: Doug Culnane <doug@culnane.net>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
…hab#15101)

* [renault] Support for MyDacia accounts and Dacia Spring car

Signed-off-by: Doug Culnane <doug@culnane.net>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[renault] Support for MyDacia accounts and Dacia Spring car
2 participants