Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[growatt] Binding for Growatt solar inverters #15120

Merged
merged 153 commits into from Jan 20, 2024
Merged

[growatt] Binding for Growatt solar inverters #15120

merged 153 commits into from Jan 20, 2024

Conversation

andrewfg
Copy link
Contributor

Initial contribution for Growatt binding for solar inverters.

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

@andrewfg andrewfg added new binding If someone has started to work on a binding. For a new binding PR. work in progress A PR that is not yet ready to be merged labels Jun 19, 2023
@andrewfg andrewfg requested a review from a team as a code owner June 19, 2023 17:55
@andrewfg andrewfg self-assigned this Jun 19, 2023
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/growatt-binding/147357/5

@andrewfg andrewfg removed the work in progress A PR that is not yet ready to be merged label Sep 10, 2023
@andrewfg andrewfg changed the title [growatt] new binding for Growatt solar inverters [growatt] Binding for Growatt solar inverters Sep 10, 2023
@andrewfg
Copy link
Contributor Author

andrewfg commented Sep 10, 2023 •
edited

TODO: some channel names and descriptions need to be changed -- 'solar-power' is actually "inverter output" and similarly for 'pv-output-power'..

EDIT: done.

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/what-solar-pv-inverter-s-do-you-have-working-with-openhab-and-how/106595/68

@mstormi
Copy link
Contributor

mstormi commented Oct 9, 2023

@openhab/add-ons-maintainers ping would you mind having a look at reviewing? Thanks.

@andrewfg
Copy link
Contributor Author

@openhab/add-ons-maintainers just for info, this has been running 7/24 on my operative system for 5 weeks now without any issues. :)

image

@andrewfg
[growatt] initial contribution
93d17d1 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] beta
f0eceed 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] fix doc typos
9a5688d 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] fix logger prefixes
4d472b5 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] normalise channels
aa49c9d 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] typo
f9440e4
@andrewfg
[growatt] fix channel names
ce5b1e8 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] xml and properties
8f6e8eb 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] initialization and discovery
8780b0e 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] fix translation issue
9b0203d 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] tweaks to thing xml
f9e6871 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] improve documentation for grott
fa41634 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] make some channels advanced
345d8bc 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] cleanup discovery & factory; edit .xml .properties files
aaddb72 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] state of charge
cda56c4 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] improve readme
f57a671 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] tweaks
a7ad73b 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] pom
f8bfa84 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] spotless warnings, oh 3.4.x compatibility, grott double esc…
f88ec53 
…aping

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@lsiepel lsiepel requested a review from a team December 29, 2023 13:25
@lsiepel
Copy link
Contributor

lsiepel commented Dec 29, 2023

@andrewfg it might help if you manage to fix the commits with missing sign-offs.

@andrewfg
Adopt user feedback on meter synonyms and tests
13880be 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
Improve logging; Tweak synonyms
e5b7b40 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] implement tlx inverter (wip)
3b58ba1 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] fix build
c1792fb 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
Implement tlx settings
0132ecc 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
Accept null arguments
a15173e 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] fix rule example
e9c2a01 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] update copyright header
9ade0be 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg requested review from lsiepel and wborn January 7, 2024 11:19
@andrewfg
[growatt] fix channel uom errors
9a8638c 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] corrections to readme
ac313ae 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[growatt] validate domain, trust certificates
265282f 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
Merge branch 'openhab:main' into growatt
7a654fc
@andrewfg
[growatt] revert prior; use OH stock createHttpClient()
04b7866 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
lsiepel
lsiepel requested changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

there are some files left that i have to examine further, but i don't want to hold back these first findings. In general it looks clean. Also nice to see tests and thanks for correcting the pom binding order with groupepsa.

bundles/org.openhab.binding.growatt/src/main/feature/feature.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.growatt/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.growatt/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.growatt/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.growatt/README.md Outdated Show resolved Hide resolved
...nhab.binding.growatt/src/main/java/org/openhab/binding/growatt/internal/dto/GrottValues.java Outdated Show resolved Hide resolved
bundles/org.openhab.binding.growatt/src/main/resources/OH-INF/addon/addon.xml Show resolved Hide resolved
bundles/org.openhab.binding.growatt/src/main/resources/OH-INF/i18n/growatt.properties Outdated Show resolved Hide resolved
bundles/org.openhab.binding.growatt/src/main/resources/OH-INF/i18n/growatt.properties Outdated Show resolved Hide resolved
bundles/org.openhab.binding.growatt/src/main/resources/OH-INF/i18n/growatt.properties Outdated Show resolved Hide resolved
@andrewfg
[growatt] adopt reviewer suggestions
0070b7f 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
Delete manufacturer logo
e2263d3 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg requested a review from lsiepel January 17, 2024 14:53
@andrewfg andrewfg mentioned this pull request Jan 17, 2024
Merged
@andrewfg
[growatt] adopt reviewer suggestions for shorter labels
a9912f4 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
lsiepel
lsiepel approved these changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@lsiepel lsiepel merged commit 6f7b5b5 into openhab:main Jan 20, 2024
3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Jan 20, 2024
@andrewfg andrewfg deleted the growatt branch January 23, 2024 14:12
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 27, 2024
@andrewfg @andrasU
[growatt] Binding for Growatt solar inverters (openhab#15120)
60da9a0 
* [growatt] initial contribution

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@andrewfg @austvik
[growatt] Binding for Growatt solar inverters (openhab#15120)
7ef3b53 
* [growatt] initial contribution

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-pace david-pace david-pace approved these changes

@lsiepel lsiepel lsiepel approved these changes

@wborn wborn Awaiting requested review from wborn

Assignees

@andrewfg andrewfg

Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet