Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openwebnet] Fix update of Thermo Central Unit atLeastOneProbeX channels and refactoring #15269

Merged
merged 5 commits into from Jul 18, 2023

Conversation

mvalla
Copy link
Contributor

@mvalla mvalla commented Jul 18, 2023

This is a cumulative PR to primarly fix handling of Thermo Central Unit state channels atLeastOneProbeX that were not updated correctly.
Thanks to a refactoring it also fixes other smaller issues related to thermo Central Unit channels.
The PR has been tested with one community user and with some simulated integration tests.
Lib openwebnet4j bumped to version 0.10.1.
Fixes #15103
Fixes #14449
Fixes #12599

Fixes openhab#12599

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Fixes openhab#14449

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
…nhab#15103

Bumped lib openwebnet4j to 0.10.1

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla mvalla added the bug An unexpected problem or unintended behavior of an add-on label Jul 18, 2023
@mvalla mvalla requested a review from lolodomo July 18, 2023 06:54
@mvalla
Copy link
Contributor Author

mvalla commented Jul 18, 2023

@lolodomo also this one should be included in OH4 if you can review it quickly !
This is quite a good catch as it closes 3 issues.
I have been working on it since past month and tested it with one community user plus some integration tests on my own.
It works much better than current OH3 code.

@lolodomo
Copy link
Contributor

@lolodomo also one this should be included in OH4 if you can review it quickly !

Too late for me but maybe another @openhab/add-ons-maintainers can do it?

@jlaur jlaur changed the title [openwebnet] Fixes update of Thermo Central Unit atLeastOneProbeX channels and refactoring [openwebnet] Fix update of Thermo Central Unit atLeastOneProbeX channels and refactoring Jul 18, 2023
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's merge!

@kaikreuzer kaikreuzer merged commit 005d594 into openhab:main Jul 18, 2023
3 checks passed
@kaikreuzer kaikreuzer added this to the 4.0 milestone Jul 18, 2023
@mvalla
Copy link
Contributor Author

mvalla commented Jul 19, 2023

great!

@mvalla mvalla deleted the openwebnet-thermo-channel-fixes branch November 19, 2023 13:45
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
…els and refactoring (openhab#15269)

* [openwebnet] Fixes changing and startup value for Weekly/Scenario modes
Fixes openhab#12599
* [openwebnet] Thermo: Fixed CU setpointTemp not restored
Fixes openhab#14449
* [openwebnet] fix update of atLeastOneProbeX channels for CU Fixes openhab#15103
Bumped lib openwebnet4j to 0.10.1

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
3 participants