[rrd4j] Fix database start time #15277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <github@klug.nrw>
|
@J-N-K - thanks! Just to be sure: I can reproduce this consistently when creating a new item while my system is not particularly busy. So the problem, at least for me, is not only when creating a lot of files. Do you think this is the same issue as fixed by this PR? |
|
I guess it really depends on timing. In my tests 8/10 times I ran into the error when linking a newly created item to a channel. After the fix it was 0/10. |
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15270
The reason is that newly created RRD files are initialized with a timestamp of (now-1). When a lot of files are created, it may take longer than a second and the timestamp of the event and the timestamp of the creation are the same. I have now increased the start time offset to one step size (usually 10s).