[nuvo] Include NuvoNet source favorites in zone favorite channel
#15292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
mlobstein
added
the
enhancement
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
mlobstein
added
rebuild
jlaur
approved these changes
Jul 24, 2023
...hab.binding.nuvo/src/main/java/org/openhab/binding/nuvo/internal/communication/NuvoEnum.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Sep 29, 2023
…penhab#15292) * Include NuvoNet source favorites in zone `favorite` channel * Use existing constants * VALID_SOURCES to enum list Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…penhab#15292) * Include NuvoNet source favorites in zone `favorite` channel * Use existing constants * VALID_SOURCES to enum list Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to accomplish a minor refactoring by standardizing the use of the Zone/Source enum instead of numeric string keys that were inconsistently implemented.
One small new feature is included that improves the utility of the
favoritechannel in each zone. In additional to the 12 built-in zone favorites, any favorites specified by the user for an openHAB NuvoNet source (visible in the physical keypad) are also displayed and can be selected by thefavoritechannel.