Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[surepetcare] Fix possible timeout bug #15411

Merged
merged 3 commits into from
Aug 21, 2023
Merged

[surepetcare] Fix possible timeout bug #15411

merged 3 commits into from
Aug 21, 2023

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Aug 12, 2023 •
edited

@lsiepel
Fix openhab#11527
ff6fd06 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel
Minor java 17 refactoring
f0a14b0 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel
Spotless
b92edf5 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Aug 12, 2023
renescherer
renescherer approved these changes Aug 12, 2023
View reviewed changes
Copy link
Contributor

@renescherer renescherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the improvement.

@lsiepel lsiepel requested a review from a team August 21, 2023 18:51
wborn
wborn approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit f2fc056 into openhab:main Aug 21, 2023
3 checks passed
@wborn wborn added this to the 4.1 milestone Aug 21, 2023
@wborn
Copy link
Member

wborn commented Aug 21, 2023

I think other add-ons have similar issues after briefly looking at the search results of request.send().

@lsiepel lsiepel deleted the surepetcare-timeout branch August 21, 2023 19:43
@lsiepel
Copy link
Contributor Author

lsiepel commented Aug 21, 2023

I think other add-ons have similar issues after briefly looking at the search results of request.send().

I’ll look at those too, next week. Thanks.

@lsiepel lsiepel mentioned this pull request Aug 26, 2023
Merged
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Sep 29, 2023
@lsiepel @Pshatsillo
[surepetcare] Fix possible timeout bug (openhab#15411)
75a3ae3 
Fix openhab#11527

* Minor java 17 refactoring
* Spotless

Signed-off-by: lsiepel <leosiepel@gmail.com>
This was referenced Dec 20, 2023
Closed
Merged
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@lsiepel @austvik
[surepetcare] Fix possible timeout bug (openhab#15411)
606af2a 
Fix openhab#11527

* Minor java 17 refactoring
* Spotless

Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renescherer renescherer renescherer approved these changes

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

[surepetcare] Potential issue with transient network connectivity
3 participants
@lsiepel @wborn @renescherer